1624989 - Move RTCPeerConnection's operations chain to c++

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P2)

Description

[Byron Campen [:bwc]]

We should do this before moving RTCRtpSender to c++, because RTCRtpSender.replaceTrack needs to the use the PC's operations chain, and it will be much cleaner if we do this first.

Comment 1

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b14486f665fc55c4081fa7dc7f43c8819ec3c813

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63665be511f888cfe66e4c7bd80139fce54d866d

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee9a46c76b2431be3de2a22d60b4fc3fc078b0e3

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ef61d431a3cef0294cc2a2467a8da2bacf219ce

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b91a9bfea30aba35ca0ec421796b349f56da1971

Comment 6

[Byron Campen [:bwc]]

This is really unwieldy right now, because there is presently no c++ version of Then for dom::Promise that allows the behavior for rejection to be specified. We could just convert everything to MozPromise and back, but that would be pretty gross and I would like to avoid it.

I think the only reasonable way forward is to write something similar to Promise::ThenWithCycleCollectedArgs that allows a rejection function to be specified in such a way that a promise rejection can lead to a promise resolution in the next step in the chain.

Comment 7

[Byron Campen [:bwc]]

Attachment: WIP: Bug 1624989: (WIP) Add Promise::ThenAndCatchWithCycleCollectedArgs

Comment 8

[Byron Campen [:bwc]]

Attachment: WIP: Bug 1624989: (WIP) Move RTCPeerConnection's operations chain to c++

Depends on D140357

Comment 9

[Byron Campen [:bwc]]

Attachment: WIP: Bug 1624989: (WIP) Add a reentrancy check that might be useful.

Depends on D140358

Comment 10

[Byron Campen [:bwc]]

Attachment: Bug 1624989: Move RTCPeerConnection's operations chain to c++ r?jib

Comment 11

[Byron Campen [:bwc]]

Attachment: Bug 1624989: Some simplifications that are possible because PeerConnectionImpl is cycle-collected. r?jib

This happens to fix a failure in webrtc/RTCPeerConnection-restartIce.https.html.

Depends on D141738

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=f980fc9a9623edf4498dd8949867a3bf7d7fdf76
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad4af43f1d83b03fb61354678fffb5adfd204762
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5fb625467675d518002093d83be493c14423783
https://treeherder.mozilla.org/#/jobs?repo=try&revision=143596ae0cf492db529c98f446e56371e993d369

Some --full pushes:
https://treeherder.mozilla.org/jobs?repo=try&revision=1e1d3f2371c15249d917d62fccd7e0031bacd788
https://treeherder.mozilla.org/jobs?repo=try&revision=e38f3adc4d43a26f7c5269969677f5d854cb07b4

Comment 13

[Byron Campen [:bwc]]

Try looks the same as baseline.

Comment 14

[Byron Campen [:bwc]]

Rebased, here's more try pushes:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9bb285ba25b1a773c3026712a39b7c1838d7eaf6
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c8c88622b825473e00957dde4af6cf989c81a29

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d570e7369906
Move RTCPeerConnection's operations chain to c++ r=jib,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/235f461a1229
Some simplifications that are possible because PeerConnectionImpl is cycle-collected. r=jib

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d570e7369906
https://hg.mozilla.org/mozilla-central/rev/235f461a1229