Move RTCPeerConnection's operations chain to c++
Categories
(Core :: WebRTC: Signaling, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox101 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(2 files, 3 obsolete files)
We should do this before moving RTCRtpSender to c++, because RTCRtpSender.replaceTrack needs to the use the PC's operations chain, and it will be much cleaner if we do this first.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b14486f665fc55c4081fa7dc7f43c8819ec3c813
Assignee | ||
Comment 2•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=63665be511f888cfe66e4c7bd80139fce54d866d
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee9a46c76b2431be3de2a22d60b4fc3fc078b0e3
Assignee | ||
Comment 4•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ef61d431a3cef0294cc2a2467a8da2bacf219ce
Assignee | ||
Comment 5•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b91a9bfea30aba35ca0ec421796b349f56da1971
Assignee | ||
Comment 6•1 year ago
|
||
This is really unwieldy right now, because there is presently no c++ version of Then for dom::Promise that allows the behavior for rejection to be specified. We could just convert everything to MozPromise and back, but that would be pretty gross and I would like to avoid it.
I think the only reasonable way forward is to write something similar to Promise::ThenWithCycleCollectedArgs that allows a rejection function to be specified in such a way that a promise rejection can lead to a promise resolution in the next step in the chain.
Assignee | ||
Comment 7•1 year ago
|
||
Assignee | ||
Comment 8•1 year ago
|
||
Depends on D140357
Assignee | ||
Comment 9•1 year ago
|
||
Depends on D140358
Assignee | ||
Comment 10•1 year ago
|
||
Assignee | ||
Comment 11•1 year ago
|
||
This happens to fix a failure in webrtc/RTCPeerConnection-restartIce.https.html.
Depends on D141738
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Comment 12•1 year ago
|
||
https://treeherder.mozilla.org/jobs?repo=try&revision=f980fc9a9623edf4498dd8949867a3bf7d7fdf76
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad4af43f1d83b03fb61354678fffb5adfd204762
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5fb625467675d518002093d83be493c14423783
https://treeherder.mozilla.org/#/jobs?repo=try&revision=143596ae0cf492db529c98f446e56371e993d369
Some --full pushes:
https://treeherder.mozilla.org/jobs?repo=try&revision=1e1d3f2371c15249d917d62fccd7e0031bacd788
https://treeherder.mozilla.org/jobs?repo=try&revision=e38f3adc4d43a26f7c5269969677f5d854cb07b4
Assignee | ||
Comment 13•1 year ago
|
||
Try looks the same as baseline.
Assignee | ||
Comment 14•1 year ago
|
||
Comment 15•1 year ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d570e7369906 Move RTCPeerConnection's operations chain to c++ r=jib,webidl,smaug https://hg.mozilla.org/integration/autoland/rev/235f461a1229 Some simplifications that are possible because PeerConnectionImpl is cycle-collected. r=jib
Comment 16•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d570e7369906
https://hg.mozilla.org/mozilla-central/rev/235f461a1229
Description
•