1765418 - Unsupported notification is not displayed on restart

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Mark Banner (:standard8)]

I noticed this by code inspection - there is some code in UpdateListener.init that is meant to display the unsupported notification to the application menu on reset if the preference is set.

Unfortunately due to the lazy getter in BrowserGlue and nothing to trigger it, the init function never gets called.

It would probably be better if it moved to a task run by _scheduleStartupIdleTasks.

STR:

1. With a Firefox profile setup, via about:config add a preference app.update.unsupported.url with value https://example.com.
2. Restart Firefox

Actual Results

Nothing is displayed in the application menu.

Expected Results

The application menu has a warning sign, and provides information about being unable to update.

Comment 1

[Mark Banner (:standard8)]

Note, I'm not sure when this was introduced, bug 1521427 first implemented this.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1765418 - Unsupported notification is not displayed on restart. r?bytesized

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6612b745e97c
Unsupported notification is not displayed on restart. r=bytesized,application-update-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

Backed out 2 changesets (bug 1765418, bug 1765427) for causing bc failures in browser_doorhanger_bc_check_unsupported.

Backout link: https://hg.mozilla.org/integration/autoland/rev/d9abb49c107bfa10a2623d71d0956affe67cc1c6

Push with failures

Failure log

Comment 5

[Mark Banner (:standard8)]

I missed that, I've fixed the test now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1989273b7efe
Unsupported notification is not displayed on restart. r=bytesized,application-update-reviewers

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/1989273b7efe