1765427 - initializedModules in BrowserGlue are never initialised

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Mark Banner (:standard8)]

The initializedModules in BrowserGlue are never initialised - because they are using lazy getters and nothing triggers them, they never get triggered.

This is also demonstrated by the fact that ContentPrefServiceParent.alwaysInit was removed in bug 1645538 but hasn't been throwing.

Bug 1765418 is handling the UpdateListener case, this bug can handle removing the remains.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1765427 - Remove initializedModules from BrowserGlue as they don't actually work. r?mak

Depends on D144060

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c48b6682930
Remove initializedModules from BrowserGlue as they don't actually work. r=mak

Comment 3

[Sandor Molnar[:smolnar]]

Backed out 2 changesets (bug 1765418, bug 1765427) for causing bc failures in browser_doorhanger_bc_check_unsupported.

Backout link: https://hg.mozilla.org/integration/autoland/rev/d9abb49c107bfa10a2623d71d0956affe67cc1c6

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee0ab9901b3c
Remove initializedModules from BrowserGlue as they don't actually work. r=mak

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ee0ab9901b3c