1766080 - support comm-strings split in mach build installers-$AB_CD and langpack-$AB_CD

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Rob Lemley [:rjl]]

Developers that need to generate localized Thunderbird builds and langpacks with mach build installers-$AB_CD and mach build langpack-$AB_CD will need to be supported with the l10n-comm breakout from l10n-central/gecko-strings.

The installers-$AB_CD make target will clone the requested l10n-central repository to ~/.mozbuild/l10n-central if it doesn't already exist. There's no support for automaticaly updating a repo.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1766080 - Support l10n-comm split for developers building localized builds. r=dandarnell

Developers that want to produce localized builds and/or langpacks can do so
with mach build installers-$LANG. This is implemented in toolkit/locales/l10n.mk.
There's support for automatically cloning a l10n-central repository into
$HOME/.mozbuild (no update support). To avoid confusion, the installers-$LANG
make target should download what's needed from the l10n-central repository and
l10n-comm and merge the them like CI language repacks will do.

L10N_CO is defined in l10n.mk as a single "hg clone" command. It's executed
when necessary for local developers. This patch overwrites L10N_CO with a
Python script that clones the two repositories and copies them to the expected
location.

The no-update support caveat still applies with the added note that what ends
up in ~/.mozbuild/l10n-central/{lang} is no longer a repository clone that
the developer can run "hg pull" in to get the latest changes. To update,
remove the directory and a fresh copy will get built.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bbe4dd440ed8
Support l10n-comm split for developers building localized builds. r=dandarnell

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: Bug 1766080 - Follow-up: Pass str to file_copier, fix destination path for local l10n builds. r=rjl

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/af38f50109dd
Follow-up: Pass str to file_copier, fix destination path for local l10n builds. r=rjl

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9273527 [details]
Bug 1766080 - Support l10n-comm split for developers building localized builds. r=dandarnell

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: No user impact, code not used in CI builds
Testing completed (on c-c, etc.): rnons tested on beta
Risk to taking this patch (and alternatives if risky):
Minimal risk. This change is for developers building localized builds. Rnons tested and submitted a fix that's not been on beta yet, but should be okay.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9273527 [details]
Bug 1766080 - Support l10n-comm split for developers building localized builds. r=dandarnell

[Triage Comment]
approved for esr102 (and the follow up patch)

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.7.0:
https://hg.mozilla.org/releases/comm-esr102/rev/03716c331431
https://hg.mozilla.org/releases/comm-esr102/rev/73ec8acffaeb