1766377 - Fix sign-compare warnings in Windows builds

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Mike Hommey [:glandium]]

mozglue/misc/PreXULSkeletonUI.cpp(319,26): error: comparison of integers of different signs: 'std::basic_string<char>::size_type' (aka 'unsigned long long') and 'int' [-Werror,-Wsign-compare]
    while (line.length() > whitespace &&
           ~~~~~~~~~~~~~ ^ ~~~~~~~~~~
mozglue/misc/PreXULSkeletonUI.cpp(1003,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 1; i < noPlaceholderSpans.length(); i++) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
mozglue/misc/PreXULSkeletonUI.cpp(1710,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
  for (int i = 0; i < dataLen / (2 * sizeof(double)); i++) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
security/sandbox/chromium-shim/sandbox/win/permissionsService.cpp(40,16): error: comparison of integers of different signs: 'int' and 'const std::basic_string<wchar_t>::size_type' (aka 'const unsigned long long') [-Werror,-Wsign-compare]
  if (slashIdx != std::wstring::npos) {
      ~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~
browser/components/shell/WindowsUserChoice.cpp(233,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare]
    for (int j = 0; j < DWORDS_PER_BLOCK; ++j) {
                    ~ ^ ~~~~~~~~~~~~~~~~
browser/components/shell/WindowsUserChoice.cpp(388,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 0; i < ArrayLength(exts); ++i) {
                  ~ ^ ~~~~~~~~~~~~~~~~~
browser/components/shell/nsWindowsShellService.cpp(1223,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 0; i < ArrayLength(shortcutCSIDLs); ++i) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
browser/components/shell/nsWindowsShellService.cpp(1490,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 0; i < ArrayLength(folders); ++i) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~
accessible/windows/msaa/Compatibility.cpp(120,21): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare]
  if (exceptionCode == RPC_E_CANTCALLOUT_ININPUTSYNCCALL && NS_IsMainThread()) {
      ~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(118,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
        tag == SCTAG_DOM_WORKER_PRINCIPAL)) {
        ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(117,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
        tag == SCTAG_DOM_EXPANDED_PRINCIPAL ||
        ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(116,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
        tag == SCTAG_DOM_CONTENT_PRINCIPAL ||
        ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(115,48): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (!(tag == SCTAG_DOM_NULL_PRINCIPAL || tag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
                                           ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(115,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (!(tag == SCTAG_DOM_NULL_PRINCIPAL || tag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
        ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(206,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_SYSTEM_PRINCIPAL) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(208,19): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  } else if (aTag == SCTAG_DOM_NULL_PRINCIPAL) {
             ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(217,19): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  } else if (aTag == SCTAG_DOM_EXPANDED_PRINCIPAL) {
             ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(239,19): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  } else if (aTag == SCTAG_DOM_CONTENT_PRINCIPAL) {
             ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(299,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_WORKER_PRINCIPAL) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/Document.cpp(14003,39): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::FullscreenRoots::(unnamed enum at dom/base/Document.cpp:13965:3)' [-Werror,-Wsign-compare]
  return FullscreenRoots::Find(aRoot) != NotFound;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~
dom/base/Document.cpp(14040,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::FullscreenRoots::(unnamed enum at dom/base/Document.cpp:13965:3)' [-Werror,-Wsign-compare]
  if (index == NotFound || !sInstance) {
      ~~~~~ ^  ~~~~~~~~
dom/base/StructuredCloneHolder.cpp(435,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_EXPANDED_PRINCIPAL) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(434,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_CONTENT_PRINCIPAL ||
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(433,48): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_NULL_PRINCIPAL || aTag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
                                          ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(433,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_NULL_PRINCIPAL || aTag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(741,15): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      if (tag == SCTAG_DOM_BLOB) {
          ~~~ ^  ~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(763,22): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      } else if (tag == SCTAG_DOM_DIRECTORY) {
                 ~~~ ^  ~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(957,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_BLOB) {
      ~~~~ ^  ~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(961,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_DIRECTORY) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(965,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_FILELIST) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(969,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_FORMDATA) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(973,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_IMAGEBITMAP &&
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(986,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_STRUCTURED_CLONE_HOLDER) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(990,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_WASM_MODULE &&
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(996,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_INPUTSTREAM) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1000,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_BROWSING_CONTEXT) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1004,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_CLONED_ERROR_OBJECT) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1124,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_MAP_MESSAGEPORT) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1152,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_CANVAS &&
      ~~~~ ^  ~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1171,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_IMAGEBITMAP &&
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IDBObjectStore.cpp(406,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_MUTABLEFILE) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IDBObjectStore.cpp(405,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
                                ~~~~ ^  ~~~~~~~~~~~~~~
dom/indexedDB/IDBObjectStore.cpp(405,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
      ~~~~ ^  ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(132,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_BLOB) {
      ~~~~ ^  ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(140,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_FILE_WITHOUT_LASTMODIFIEDDATE) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,45): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
                                       ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
                                ~~~~ ^  ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
      ~~~~ ^  ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(378,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_FILE_WITHOUT_LASTMODIFIEDDATE ||
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(383,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
    if (aTag == SCTAG_DOM_WASM_MODULE) {
        ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(416,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
    if (aTag == SCTAG_DOM_MUTABLEFILE) {
        ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,45): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
                                       ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
                                ~~~~ ^  ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
      ~~~~ ^  ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(378,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == SCTAG_DOM_FILE_WITHOUT_LASTMODIFIEDDATE ||
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(383,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
    if (aTag == SCTAG_DOM_WASM_MODULE) {
        ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(416,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
    if (aTag == SCTAG_DOM_MUTABLEFILE) {
        ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(220,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
    if (aData.tag == SCTAG_DOM_BLOB) {
        ~~~~~~~~~ ^  ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(220,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
    if (aData.tag == SCTAG_DOM_BLOB) {
        ~~~~~~~~~ ^  ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,45): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
      aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
                                       ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
dom/media/ipc/RDDProcessManager.cpp(320,21): error: comparison of integers of different signs: 'base::ProcessId' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
      gpuProcessPid != -1 ? gpuProcessPid : base::GetCurrentProcId();
      ~~~~~~~~~~~~~ ^  ~~
dom/media/ipc/RDDProcessManager.cpp(332,21): error: comparison of integers of different signs: 'base::ProcessId' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
  if (gpuProcessPid != -1) {
      ~~~~~~~~~~~~~ ^  ~~
dom/media/platforms/wmf/MFTDecoder.cpp(85,23): error: comparison of integers of different signs: 'int' and 'UINT32' (aka 'unsigned int') [-Werror,-Wsign-compare]
    for (int i = 1; i < actsNum; i++) {
                    ~ ^ ~~~~~~~
dom/network/TCPSocket.cpp(973,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsISocketTransport::(unnamed enum at obj-build/dist/include/nsISocketTransport.h:102:3)' [-Werror,-Wsign-compare]
  if (static_cast<uint32_t>(aStatus) !=
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
dom/security/ReferrerInfo.cpp(216,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-build/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare]
          rejectedReason !=
          ~~~~~~~~~~~~~~ ^
gfx/2d/Factory.cpp(1276,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
  for (int y = 0; y < height; y++) {
                  ~ ^ ~~~~~~
gfx/thebes/gfxGDIFont.cpp(454,13): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare]
    if (ret == E_PENDING) {
        ~~~ ^  ~~~~~~~~~
gfx/layers/d3d11/CompositorD3D11.cpp(1096,36): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
        swapDesc.BufferDesc.Height == mSize.height) ||
        ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
gfx/layers/d3d11/CompositorD3D11.cpp(1095,35): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
  if (((swapDesc.BufferDesc.Width == mSize.width &&
        ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~
intl/lwbrk/nsUniscribeBreaker.cpp(121,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
  for (int i = 0; i < aLength; ++i) {
                  ~ ^ ~~~~~~~
intl/lwbrk/nsUniscribeBreaker.cpp(132,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
    for (int i = 0; i < aLength; ++i) {
                    ~ ^ ~~~~~~~
intl/lwbrk/nsUniscribeBreaker.cpp(138,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
    for (int i = 0; i < aLength; ++i) {
                    ~ ^ ~~~~~~~
gfx/thebes/D3D11Checks.cpp(129,21): error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare]
    if (resultColor != 0xffffff00) {
        ~~~~~~~~~~~ ^  ~~~~~~~~~~
gfx/thebes/D3D11Checks.cpp(154,23): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
    for (int i = 0; i < PR_ARRAY_SIZE(checkModules); i += 1) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/thebes/D3D11Checks.cpp(409,14): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'UINT' (aka 'unsigned int') [-Werror,-Wsign-compare]
  if (vendor != desc.VendorId) {
      ~~~~~~ ^  ~~~~~~~~~~~~~
gfx/thebes/gfxDWriteFontList.cpp(1248,39): error: comparison of integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare]
        addFamily(names[index], index != sysLocIndex);
                                ~~~~~ ^  ~~~~~~~~~~~
ipc/chromium/src/base/thread_local_win.cc(18,14): error: comparison of integers of different signs: 'base::ThreadLocalPlatform::SlotType' (aka 'int') and 'DWORD' (aka 'unsigned long') [-Werror,-Wsign-compare]
  CHECK(slot != TLS_OUT_OF_INDEXES);
        ~~~~ ^  ~~~~~~~~~~~~~~~~~~
gfx/layers/d3d11/TextureD3D11.cpp(1278,30): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
          currentDesc.Height != mSize.height ||
          ~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
gfx/layers/d3d11/TextureD3D11.cpp(1277,29): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
      if (currentDesc.Width != mSize.width ||
          ~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~
gfx/layers/ipc/SharedSurfacesParent.cpp(360,38): error: comparison of integers of different signs: 'base::ProcessId' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
    if (!gpm || gpm->GPUProcessPid() != -1) {
                ~~~~~~~~~~~~~~~~~~~~ ^  ~~
gfx/layers/ipc/ContentCompositorBridgeParent.cpp(248,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'int32_t' (aka 'int') [-Werror,-Wsign-compare]
  if (sequenceNum == status.sequenceNumber() && !dm->HasDeviceReset()) {
      ~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~
ipc/glue/WindowsMessageLoop.cpp(381,44): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
        if (objId == OBJID_CLIENT || objId == MOZOBJID_UIAROOT) {
                                     ~~~~~ ^  ~~~~~~~~~~~~~~~~
ipc/glue/WindowsMessageLoop.cpp(381,19): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Werror,-Wsign-compare]
        if (objId == OBJID_CLIENT || objId == MOZOBJID_UIAROOT) {
            ~~~~~ ^  ~~~~~~~~~~~~
js/src/vtune/ittnotify_static.c(490,42): error: comparison of integers of different signs: 'unsigned int' and '__itt_metadata_type' [-Werror,-Wsign-compare]
        if (h->nameW != NULL  && h->type == type && !wcscmp(h->nameW, name) && ((h->domainW == NULL && domain == NULL) ||
                                 ~~~~~~~ ^  ~~~~
js/src/vtune/ittnotify_static.c(534,42): error: comparison of integers of different signs: 'unsigned int' and '__itt_metadata_type' [-Werror,-Wsign-compare]
        if (h->nameA != NULL  && h->type == type && !__itt_fstrcmp(h->nameA, name) && ((h->domainA == NULL && domain == NULL) ||
                                 ~~~~~~~ ^  ~~~~
js/src/vtune/ittnotify_static.c(566,42): error: comparison of integers of different signs: 'unsigned int' and '__itt_metadata_type' [-Werror,-Wsign-compare]
        if (h->nameW != NULL  && h->type == type && !wcscmp(h->nameW, name) && ((h->domainW == NULL && domain == NULL) ||
                                 ~~~~~~~ ^  ~~~~
js/src/vtune/ittnotify_static.c(609,42): error: comparison of integers of different signs: 'unsigned int' and '__itt_metadata_type' [-Werror,-Wsign-compare]
        if (h->nameA != NULL  && h->type == type && !__itt_fstrcmp(h->nameA, name) && ((h->domainA == NULL && domain == NULL) ||
                                 ~~~~~~~ ^  ~~~~
ipc/glue/MessageChannel.cpp(2145,13): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'const base::ProcessId' (aka 'const unsigned long') [-Werror,-Wsign-compare]
    if (pid != base::kInvalidProcessId &&
        ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~
js/xpconnect/src/ExportHelpers.cpp(59,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'xpc::StackScopedCloneTags' [-Werror,-Wsign-compare]
    if (aTag == SCTAG_REFLECTOR) {
        ~~~~ ^  ~~~~~~~~~~~~~~~
js/xpconnect/src/ExportHelpers.cpp(79,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'xpc::StackScopedCloneTags' [-Werror,-Wsign-compare]
    if (aTag == SCTAG_FUNCTION) {
        ~~~~ ^  ~~~~~~~~~~~~~~
js/xpconnect/src/ExportHelpers.cpp(98,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'xpc::StackScopedCloneTags' [-Werror,-Wsign-compare]
    if (aTag == SCTAG_BLOB) {
        ~~~~ ^  ~~~~~~~~~~
js/xpconnect/src/XPCCallContext.cpp(90,12): error: comparison of integers of different signs: 'unsigned int' and 'XPCCallContext::(unnamed enum at js/xpconnect/src/xpcprivate.h:671:3)' [-Werror,-Wsign-compare]
  if (argc != NO_ARGS) {
      ~~~~ ^  ~~~~~~~
toolkit/components/extensions/webidl-api/ExtensionAPIRequestForwarder.cpp(250,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
  if (aTag == dom::SCTAG_DOM_CLONED_ERROR_OBJECT) {
      ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/components/antitracking/StorageAccess.cpp(175,23): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-build/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare]
  if (aRejectedReason ==
      ~~~~~~~~~~~~~~~ ^
toolkit/components/antitracking/StorageAccess.cpp(415,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-build/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare]
         aRejectedReason ==
         ~~~~~~~~~~~~~~~ ^
toolkit/components/antitracking/StorageAccess.cpp(428,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-build/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare]
  return aRejectedReason ==
         ~~~~~~~~~~~~~~~ ^
toolkit/crashreporter/breakpad-client/windows/crash_generation/crash_generation_server.cc(957,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare]
    for (int i = 0; i < kExceptionAppMemoryRegions; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/system/windowsproxy/ProxyUtils.cpp(27,36): error: comparison of integers of different signs: 'const int' and 'nsTArray_base::size_type' (aka 'unsigned long long') [-Werror,-Wsign-compare]
                             if (i < addr.Length()) {
                                 ~ ^ ~~~~~~~~~~~~~
xpfe/appshell/AppWindow.cpp(1900,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
  for (int i = 0; i < toolbarSprings->Length(); i++) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
widget/windows/TSFTextStore.cpp(3455,28): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare]
          range.mEndOffset == end - mComposition->StartOffset() &&
          ~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
widget/windows/TSFTextStore.cpp(3454,30): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare]
      if (range.mStartOffset == start - mComposition->StartOffset() &&
          ~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/components/aboutthirdparty/tests/gtest/TestAboutThirdParty.cpp(107,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 0; i < ArrayLength(kDirectoriesUnsorted); ++i) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
toolkit/crashreporter/client/crashreporter_win.cpp(373,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
  for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/crashreporter/client/crashreporter_win.cpp(671,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
  for (int i = 0; i < sizeof(controls) / sizeof(controls[0]); i++) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/crashreporter/client/crashreporter_win.cpp(1048,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
  for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
GTEST_IMPL_CMP_HELPER_(GT, >)
~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(139,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(151,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(164,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const int' and 'const unsigned long long' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
GTEST_IMPL_CMP_HELPER_(GT, >)
~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
GTEST_IMPL_CMP_HELPER_(GT, >)
~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
browser/components/shell/WindowsUserChoice.cpp(233,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare]
    for (int j = 0; j < DWORDS_PER_BLOCK; ++j) {
                    ~ ^ ~~~~~~~~~~~~~~~~
browser/components/shell/WindowsUserChoice.cpp(388,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 0; i < ArrayLength(exts); ++i) {
                  ~ ^ ~~~~~~~~~~~~~~~~~
toolkit/mozapps/defaultagent/SetDefaultBrowser.cpp(248,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
  for (int i = 0; i < mozilla::ArrayLength(associations); ++i) {
                  ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
widget/windows/WinIMEHandler.cpp(166,35): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Werror,-Wsign-compare]
      static_cast<DWORD>(aLParam) == OBJID_CARET) {
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~
widget/windows/nsWindow.cpp(541,37): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Werror,-Wsign-compare]
        static_cast<DWORD>(aLParam) != OBJID_CLIENT ||
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~

... and more.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1766377 - Fix some sign-compare warnings by using ProcessId more consistently.

dom/media/ipc/RDDProcessManager.cpp(320,21): error: comparison of integers of different signs: 'base::ProcessId' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
gpuProcessPid != -1 ? gpuProcessPid : base::GetCurrentProcId();
~~~~~~~~~~~~~ ^ ~~
dom/media/ipc/RDDProcessManager.cpp(332,21): error: comparison of integers of different signs: 'base::ProcessId' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
if (gpuProcessPid != -1) {
~~~~~~~~~~~~~ ^ ~~
ipc/chromium/src/base/thread_local_win.cc(18,14): error: comparison of integers of different signs: 'base::ThreadLocalPlatform::SlotType' (aka 'int') and 'DWORD' (aka 'unsigned long') [-Werror,-Wsign-compare]
CHECK(slot != TLS_OUT_OF_INDEXES);
~~~~ ^ ~~~~~~~~~~~~~~~~~~
gfx/layers/ipc/SharedSurfacesParent.cpp(360,38): error: comparison of integers of different signs: 'base::ProcessId' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
if (!gpm || gpm->GPUProcessPid() != -1) {
~~~~~~~~~~~~~~~~~~~~ ^ ~~
ipc/glue/MessageChannel.cpp(2145,13): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'const base::ProcessId' (aka 'const unsigned long') [-Werror,-Wsign-compare]
if (pid != base::kInvalidProcessId &&
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1766377 - Fix some sign-compare warnings related to enums in Windows builds.

js/xpconnect/src/ExportHelpers.cpp(59,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'xpc::StackScopedCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_REFLECTOR) {
~~~~ ^ ~~~~~~~~~~~~~~~
js/xpconnect/src/ExportHelpers.cpp(79,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'xpc::StackScopedCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_FUNCTION) {
~~~~ ^ ~~~~~~~~~~~~~~
js/xpconnect/src/ExportHelpers.cpp(98,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'xpc::StackScopedCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_BLOB) {
~~~~ ^ ~~~~~~~~~~
toolkit/components/extensions/webidl-api/ExtensionAPIRequestForwarder.cpp(250,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == dom::SCTAG_DOM_CLONED_ERROR_OBJECT) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(132,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BLOB) {
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(140,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FILE_WITHOUT_LASTMODIFIEDDATE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(435,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_EXPANDED_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(434,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_CONTENT_PRINCIPAL ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(433,48): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_NULL_PRINCIPAL || aTag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(433,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_NULL_PRINCIPAL || aTag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(741,15): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (tag == SCTAG_DOM_BLOB) {
~~~ ^ ~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(763,22): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
} else if (tag == SCTAG_DOM_DIRECTORY) {
~~~ ^ ~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(957,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BLOB) {
~~~~ ^ ~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(961,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_DIRECTORY) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(965,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FILELIST) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(969,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FORMDATA) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(973,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_IMAGEBITMAP &&
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(986,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_STRUCTURED_CLONE_HOLDER) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(990,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_WASM_MODULE &&
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(996,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_INPUTSTREAM) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1000,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BROWSING_CONTEXT) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1004,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_CLONED_ERROR_OBJECT) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1124,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_MAP_MESSAGEPORT) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1152,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_CANVAS &&
~~~~ ^ ~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1171,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_IMAGEBITMAP &&
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,45): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(378,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FILE_WITHOUT_LASTMODIFIEDDATE ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(383,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(416,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_MUTABLEFILE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,45): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(378,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FILE_WITHOUT_LASTMODIFIEDDATE ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(383,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(416,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_MUTABLEFILE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(220,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aData.tag == SCTAG_DOM_BLOB) {
~~~~~~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(220,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aData.tag == SCTAG_DOM_BLOB) {
~~~~~~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,45): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(118,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
tag == SCTAG_DOM_WORKER_PRINCIPAL)) {
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(117,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
tag == SCTAG_DOM_EXPANDED_PRINCIPAL ||
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(116,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
tag == SCTAG_DOM_CONTENT_PRINCIPAL ||
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(115,48): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (!(tag == SCTAG_DOM_NULL_PRINCIPAL || tag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(115,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (!(tag == SCTAG_DOM_NULL_PRINCIPAL || tag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(206,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_SYSTEM_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(208,19): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
} else if (aTag == SCTAG_DOM_NULL_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(217,19): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
} else if (aTag == SCTAG_DOM_EXPANDED_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(239,19): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
} else if (aTag == SCTAG_DOM_CONTENT_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(299,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_WORKER_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
js/xpconnect/src/XPCCallContext.cpp(90,12): error: comparison of integers of different signs: 'unsigned int' and 'XPCCallContext::(unnamed enum at js/xpconnect/src/xpcprivate.h:671:3)' [-Werror,-Wsign-compare]
if (argc != NO_ARGS) {
~~~~ ^ ~~~~~~~
dom/indexedDB/IDBObjectStore.cpp(406,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IDBObjectStore.cpp(405,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IDBObjectStore.cpp(405,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/base/Document.cpp(14003,39): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::FullscreenRoots::(unnamed enum at dom/base/Document.cpp:13965:3)' [-Werror,-Wsign-compare]
return FullscreenRoots::Find(aRoot) != NotFound;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~
dom/base/Document.cpp(14040,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::FullscreenRoots::(unnamed enum at dom/base/Document.cpp:13965:3)' [-Werror,-Wsign-compare]
if (index == NotFound || !sInstance) {
~~~~~ ^ ~~~~~~~~

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1766377 - Fix some sign-compare warnings related to enums in Windows builds.

js/src/jit/arm64/vixl/Instructions-vixl.h(264,41): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::MoveWideImmediateOp' [-Werror,-Wsign-compare]
return (Mask(MoveWideImmediateMask) == MOVN_x) ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~
js/src/jit/arm64/vixl/Disasm-vixl.cpp(1290,48): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::SystemExclusiveMonitorOp' [-Werror,-Wsign-compare]
if (instr->Mask(SystemExclusiveMonitorFMask) == SystemExclusiveMonitorFixed) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
js/src/jit/arm64/vixl/Disasm-vixl.cpp(1298,45): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::SystemSysRegOp' [-Werror,-Wsign-compare]
} else if (instr->Mask(SystemSysRegFMask) == SystemSysRegFixed) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
js/src/jit/arm64/vixl/Disasm-vixl.cpp(1319,43): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::SystemHintOp' [-Werror,-Wsign-compare]
} else if (instr->Mask(SystemHintFMask) == SystemHintFixed) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
js/src/jit/arm64/vixl/Disasm-vixl.cpp(1332,43): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::MemBarrierOp' [-Werror,-Wsign-compare]
} else if (instr->Mask(MemBarrierFMask) == MemBarrierFixed) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
js/src/jit/arm64/vixl/Disasm-vixl.cpp(1350,42): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::SystemSysOp' [-Werror,-Wsign-compare]
} else if (instr->Mask(SystemSysFMask) == SystemSysFixed) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
js/src/jit/arm64/vixl/Instructions-vixl.cpp(321,35): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::PCRelAddressingOp' [-Werror,-Wsign-compare]
if (Mask(PCRelAddressingMask) == ADRP) {
~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(44,40): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
return Mask(UnconditionalBranchMask) == (UnconditionalBranchFixed | BL);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(49,50): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
return Mask(UnconditionalBranchToRegisterMask) == (UnconditionalBranchToRegisterFixed | BR);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(54,50): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
return Mask(UnconditionalBranchToRegisterMask) == (UnconditionalBranchToRegisterFixed | BLR);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(69,70): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::CompareBranchOp' [-Werror,-Wsign-compare]
return Mask(CompareBranchMask) == CBZ_w || Mask(CompareBranchMask) == CBZ_x;
~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(74,71): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::CompareBranchOp' [-Werror,-Wsign-compare]
return Mask(CompareBranchMask) == CBNZ_w || Mask(CompareBranchMask) == CBNZ_x;
~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(84,31): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::SystemHintOp' [-Werror,-Wsign-compare]
return Mask(SystemHintMask) == HINT && ImmHint() == NOP;
~~~~~~~~~~~~~~~~~~~~ ^ ~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(89,31): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::SystemHintOp' [-Werror,-Wsign-compare]
return Mask(SystemHintMask) == HINT && ImmHint() == CSDB;
~~~~~~~~~~~~~~~~~~~~ ^ ~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(99,36): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::PCRelAddressingOp' [-Werror,-Wsign-compare]
return Mask(PCRelAddressingMask) == ADRP;
~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(104,39): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::MoveWideImmediateOp' [-Werror,-Wsign-compare]
return (Mask(MoveWideImmediateMask) == MOVZ_x) ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(110,39): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::MoveWideImmediateOp' [-Werror,-Wsign-compare]
return (Mask(MoveWideImmediateMask) == MOVK_x) ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~
js/src/jit/arm64/vixl/MozInstructions-vixl.cpp(115,41): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
return Mask(UnconditionalBranchFMask) == (UnconditionalBranchFixed | BL);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
js/src/jit/arm64/vixl/Instructions-vixl.h(264,41): error: comparison of integers of different signs: 'vixl::Instr' (aka 'unsigned int') and 'vixl::MoveWideImmediateOp' [-Werror,-Wsign-compare]
return (Mask(MoveWideImmediateMask) == MOVN_x) ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1766377 - Disable sign-compare warnings in third-party code.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1766377 - Fix sign-compare warnings related to Windows constants.

obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, long>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
toolkit/components/maintenanceservice/tests/gtest/ServiceStartInteractiveOnly.cpp(51,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, long, nullptr>' requested here
ASSERT_EQ(GetLastError(), ERROR_ACCESS_DENIED);
^
obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ'
^
obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ'
ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, long>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
toolkit/library/gtest/TestUCRTDepends.cpp(52,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, long, nullptr>' requested here
EXPECT_EQ(GetLastError(), ERROR_FILE_NOT_FOUND);
^
obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ'
EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
ipc/glue/WindowsMessageLoop.cpp(381,44): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
if (objId == OBJID_CLIENT || objId == MOZOBJID_UIAROOT) {
~~~~~ ^ ~~~~~~~~~~~~~~~~
ipc/glue/WindowsMessageLoop.cpp(381,19): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Werror,-Wsign-compare]
if (objId == OBJID_CLIENT || objId == MOZOBJID_UIAROOT) {
~~~~~ ^ ~~~~~~~~~~~~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, long>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
xpcom/tests/windows/TestPoisonIOInterposer.cpp(108,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, long, nullptr>' requested here
EXPECT_EQ(::GetLastError(), ERROR_IO_PENDING);
^
obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ'
EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
gfx/thebes/gfxGDIFont.cpp(454,13): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare]
if (ret == E_PENDING) {
~~~ ^ ~~~~~~~~~
accessible/windows/msaa/Compatibility.cpp(120,21): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare]
if (exceptionCode == RPC_E_CANTCALLOUT_ININPUTSYNCCALL && NS_IsMainThread()) {
~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
widget/windows/WinIMEHandler.cpp(166,35): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Werror,-Wsign-compare]
static_cast<DWORD>(aLParam) == OBJID_CARET) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
widget/windows/nsWindow.cpp(541,37): error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Werror,-Wsign-compare]
static_cast<DWORD>(aLParam) != OBJID_CLIENT ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1766377 - Fix sign-compare warnings related to IDL constants.

dom/network/TCPSocket.cpp(973,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsISocketTransport::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsISocketTransport.h:102:3)' [-Werror,-Wsign-compare]
if (static_cast<uint32_t>(aStatus) !=
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
dom/security/ReferrerInfo.cpp(216,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare]
rejectedReason !=
~~~~~~~~~~~~~~ ^
toolkit/components/antitracking/StorageAccess.cpp(175,23): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare]
if (aRejectedReason ==
~~~~~~~~~~~~~~~ ^
toolkit/components/antitracking/StorageAccess.cpp(415,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare]
aRejectedReason ==
~~~~~~~~~~~~~~~ ^
toolkit/components/antitracking/StorageAccess.cpp(428,26): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'nsIWebProgressListener::(unnamed enum at obj-aarch64-pc-mingw32/dist/include/nsIWebProgressListener.h:41:3)' [-Werror,-Wsign-compare]
return aRejectedReason ==
~~~~~~~~~~~~~~~ ^

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1766377 - Fix sign-compare warnings related to constants in gtests.

obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
GTEST_IMPL_CMP_HELPER_(GT, >)
^
obj-build/dist/include/gtest/gtest.h(1422,14): note: expanded from macro 'GTEST_IMPL_CMP_HELPER_'
if (val1 op val2) {
~~~~ ^ ~~~~
toolkit/system/windowsPackageManager/tests/gtest/TestWindowsPackageManager.cpp(22,3): note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned long long, int>' requested here
ASSERT_GT(packages.Length(), 0);
^
obj-build/dist/include/gtest/gtest.h(1891,31): note: expanded from macro 'ASSERT_GT'
^
obj-build/dist/include/gtest/gtest.h(1865,44): note: expanded from macro 'GTEST_ASSERT_GT'
ASSERT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2)
^
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long long, int>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
toolkit/system/windowsPackageManager/tests/gtest/TestWindowsPackageManager.cpp(33,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long long, int, nullptr>' requested here
ASSERT_EQ(packages.Length(), 0);
^
obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ'
^
obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ'
ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned int>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
toolkit/system/windowsDHCPClient/tests/gtest/TestDHCPUtils.cpp(232,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<int, unsigned int, nullptr>' requested here
ASSERT_EQ(0, size);
^
obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ'
^
obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ'
ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
toolkit/mozapps/defaultagent/tests/gtest/CacheTest.cpp(67,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here
ASSERT_EQ(Cache::kDefaultCapacity, 2);
^
obj-build/dist/include/gtest/gtest.h(1871,31): note: expanded from macro 'ASSERT_EQ'
^
obj-build/dist/include/gtest/gtest.h(1855,54): note: expanded from macro 'GTEST_ASSERT_EQ'
ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
GTEST_IMPL_CMP_HELPER_(GT, >)
^
obj-build/dist/include/gtest/gtest.h(1422,14): note: expanded from macro 'GTEST_IMPL_CMP_HELPER_'
if (val1 op val2) {
~~~~ ^ ~~~~
toolkit/xre/dllservices/tests/gtest/TestDLLBlocklist.cpp(123,5): note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned long long, int>' requested here
EXPECT_GT(strlen(pEntry->mName), 3);
^
obj-build/dist/include/gtest/gtest.h(1852,44): note: expanded from macro 'EXPECT_GT'
EXPECT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2)
^
In file included from Unified_cpp_xpcom_tests_gtest0.cpp:2:
In file included from xpcom/tests/gtest/Helpers.cpp:12:
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long long, int>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
xpcom/tests/gtest/TestAvailableMemoryWatcherWin.cpp(483,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long long, int, nullptr>' requested here
EXPECT_EQ(tokens.Length(), 3);
^
obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ'
EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned long long' and 'const int' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long long, int>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(211,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long long, int, nullptr>' requested here
EXPECT_EQ(collector.Data().length(), 1);
^
obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ'
EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(310,7): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here
EXPECT_EQ(evt.mLoadStatus, 0);
^
obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ'
EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
obj-build/dist/include/gtest/gtest.h(1440,28): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
GTEST_IMPL_CMP_HELPER_(GT, >)
^
obj-build/dist/include/gtest/gtest.h(1422,14): note: expanded from macro 'GTEST_IMPL_CMP_HELPER_'
if (val1 op val2) {
~~~~ ^ ~~~~
toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(332,3): note: in instantiation of function template specialization 'testing::internal::CmpHelperGT<unsigned int, int>' requested here
EXPECT_GT(aData.mNumEvents, 0);
^
obj-build/dist/include/gtest/gtest.h(1852,44): note: expanded from macro 'EXPECT_GT'
EXPECT_PRED_FORMAT2(::testing::internal::CmpHelperGT, val1, val2)
^

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1766377 - Fix remaining sign-compare warnings in Windows builds.

browser/components/shell/WindowsUserChoice.cpp(233,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare]
for (int j = 0; j < DWORDS_PER_BLOCK; ++j) {
~ ^ ~~~~~~~~~~~~~~~~
browser/components/shell/WindowsUserChoice.cpp(388,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
for (int i = 0; i < ArrayLength(exts); ++i) {
~ ^ ~~~~~~~~~~~~~~~~~
browser/components/shell/nsWindowsShellService.cpp(1225,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
for (int i = 0; i < ArrayLength(shortcutCSIDLs); ++i) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
browser/components/shell/nsWindowsShellService.cpp(1492,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
for (int i = 0; i < ArrayLength(folders); ++i) {
~ ^ ~~~~~~~~~~~~~~~~~~~~
dom/media/platforms/wmf/MFTDecoder.cpp(85,23): error: comparison of integers of different signs: 'int' and 'UINT32' (aka 'unsigned int') [-Werror,-Wsign-compare]
for (int i = 1; i < actsNum; i++) {
~ ^ ~~~~~~~
gfx/2d/Factory.cpp(1276,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
for (int y = 0; y < height; y++) {
~ ^ ~~~~~~
gfx/layers/d3d11/CompositorD3D11.cpp(1096,36): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
swapDesc.BufferDesc.Height == mSize.height) ||
~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~
gfx/layers/d3d11/CompositorD3D11.cpp(1095,35): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
if (((swapDesc.BufferDesc.Width == mSize.width &&
~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
gfx/layers/d3d11/TextureD3D11.cpp(1278,30): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
currentDesc.Height != mSize.height ||
~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~
gfx/layers/d3d11/TextureD3D11.cpp(1277,29): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
if (currentDesc.Width != mSize.width ||
~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
gfx/layers/ipc/ContentCompositorBridgeParent.cpp(248,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'int32_t' (aka 'int') [-Werror,-Wsign-compare]
if (sequenceNum == status.sequenceNumber() && !dm->HasDeviceReset()) {
~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~
gfx/thebes/D3D11Checks.cpp(129,21): error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare]
if (resultColor != 0xffffff00) {
~~~~~~~~~~~ ^ ~~~~~~~~~~
gfx/thebes/D3D11Checks.cpp(154,23): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
for (int i = 0; i < PR_ARRAY_SIZE(checkModules); i += 1) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
gfx/thebes/D3D11Checks.cpp(409,14): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'UINT' (aka 'unsigned int') [-Werror,-Wsign-compare]
if (vendor != desc.VendorId) {
~~~~~~ ^ ~~~~~~~~~~~~~
gfx/thebes/gfxDWriteFontList.cpp(1248,39): error: comparison of integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare]
addFamily(names[index], index != sysLocIndex);
~~~~~ ^ ~~~~~~~~~~~
intl/lwbrk/nsUniscribeBreaker.cpp(121,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
for (int i = 0; i < aLength; ++i) {
~ ^ ~~~~~~~
intl/lwbrk/nsUniscribeBreaker.cpp(132,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
for (int i = 0; i < aLength; ++i) {
~ ^ ~~~~~~~
intl/lwbrk/nsUniscribeBreaker.cpp(138,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
for (int i = 0; i < aLength; ++i) {
~ ^ ~~~~~~~
mozglue/misc/PreXULSkeletonUI.cpp(319,26): error: comparison of integers of different signs: 'std::basic_string<char>::size_type' (aka 'unsigned long long') and 'int' [-Werror,-Wsign-compare]
while (line.length() > whitespace &&
~~~~~~~~~~~~~ ^ ~~~~~~~~~~
mozglue/misc/PreXULSkeletonUI.cpp(1003,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
for (int i = 1; i < noPlaceholderSpans.length(); i++) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
mozglue/misc/PreXULSkeletonUI.cpp(1708,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
for (int i = 0; i < dataLen / (2 * sizeof(double)); i++) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
security/sandbox/chromium-shim/sandbox/win/permissionsService.cpp(40,16): error: comparison of integers of different signs: 'int' and 'const std::basic_string<wchar_t>::size_type' (aka 'const unsigned long long') [-Werror,-Wsign-compare]
if (slashIdx != std::wstring::npos) {
~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
toolkit/components/aboutthirdparty/tests/gtest/TestAboutThirdParty.cpp(107,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
for (int i = 0; i < ArrayLength(kDirectoriesUnsorted); ++i) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/crashreporter/breakpad-client/windows/crash_generation/crash_generation_server.cc(957,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare]
for (int i = 0; i < kExceptionAppMemoryRegions; i++) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/crashreporter/client/crashreporter_win.cpp(373,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/crashreporter/client/crashreporter_win.cpp(671,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
for (int i = 0; i < sizeof(controls) / sizeof(controls[0]); i++) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/crashreporter/client/crashreporter_win.cpp(1048,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare]
for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/mozapps/defaultagent/SetDefaultBrowser.cpp(248,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
for (int i = 0; i < mozilla::ArrayLength(associations); ++i) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/system/windowsproxy/ProxyUtils.cpp(27,36): error: comparison of integers of different signs: 'const int' and 'nsTArray_base::size_type' (aka 'unsigned long long') [-Werror,-Wsign-compare]
if (i < addr.Length()) {
~ ^ ~~~~~~~~~~~~~
toolkit/xre/dllservices/mozglue/interceptor/Arm64.h(178,28): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
if (signbits && signbits != 0xFE000000) {
~~~~~~~~ ^ ~~~~~~~~~~
obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ'
EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(35,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here
EXPECT_EQ(mCounters.Count(), N);
^
obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ'
EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(210,28): note: in instantiation of function template specialization 'ModuleLoadCounter::Remains<1>' requested here
EXPECT_TRUE(waitForOne.Remains({kTestModules[0]}, {0}));
^
toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(139,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(151,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(164,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare]
for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const int' and 'const unsigned long long' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned long long>' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(138,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<int, unsigned long long, nullptr>' requested here
EXPECT_EQ(len, ArrayLength(kExpectedArgsW));
^
widget/windows/TSFTextStore.cpp(3455,28): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare]
range.mEndOffset == end - mComposition->StartOffset() &&
~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
widget/windows/TSFTextStore.cpp(3454,30): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare]
if (range.mStartOffset == start - mComposition->StartOffset() &&
~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xpfe/appshell/AppWindow.cpp(1900,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
for (int i = 0; i < toolbarSprings->Length(); i++) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccb0fe2d2fcf
Fix some sign-compare warnings by using ProcessId more consistently. r=nika,necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/aa072cb33ec7
Fix some sign-compare warnings related to enums in Windows builds. r=emilio
https://hg.mozilla.org/integration/autoland/rev/984711675ce7
Fix some sign-compare warnings related to enums in Windows builds. r=jandem
https://hg.mozilla.org/integration/autoland/rev/8f1e8337fd0d
Disable sign-compare warnings in third-party code. r=jandem

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ccb0fe2d2fcf
https://hg.mozilla.org/mozilla-central/rev/aa072cb33ec7
https://hg.mozilla.org/mozilla-central/rev/984711675ce7
https://hg.mozilla.org/mozilla-central/rev/8f1e8337fd0d

Comment 11

[Mike Hommey [:glandium]]

Attachment: Bug 1766377 - Fixup after ccb0fe2d2fcf

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/881002d9a96b
Fixup after ccb0fe2d2fcf
https://hg.mozilla.org/integration/autoland/rev/1a6583d6e52e
Fix sign-compare warnings related to Windows constants. r=rkraesig,gfx-reviewers,sotaro
https://hg.mozilla.org/integration/autoland/rev/80d16d55c490
Fix sign-compare warnings related to IDL constants. r=anti-tracking-reviewers,necko-reviewers,kershaw,timhuang
https://hg.mozilla.org/integration/autoland/rev/e8108d6fab9f
Fix sign-compare warnings related to constants in gtests. r=nika,mossop
https://hg.mozilla.org/integration/autoland/rev/6335511477a4
Fix remaining sign-compare warnings in Windows builds. r=rkraesig,gsvelto,media-playback-reviewers,gfx-reviewers,bryce,sotaro

Comment 13

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures

Backout link

Push with failures

Failure log 1 // Failure log 2 // Failure log 3

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38403cbd82e6
Fix sign-compare warnings related to Windows constants. r=rkraesig,gfx-reviewers,sotaro
https://hg.mozilla.org/integration/autoland/rev/9ac10050264f
Fix sign-compare warnings related to IDL constants. r=anti-tracking-reviewers,necko-reviewers,kershaw,timhuang
https://hg.mozilla.org/integration/autoland/rev/6a5aa84bce70
Fix sign-compare warnings related to constants in gtests. r=nika,mossop
https://hg.mozilla.org/integration/autoland/rev/624ae1b1ac65
Fix remaining sign-compare warnings in Windows builds. r=rkraesig,gsvelto,media-playback-reviewers,gfx-reviewers,bryce,sotaro

Comment 15

[Julien Cristau [:jcristau]]

Fixup after ccb0fe2d2fcf
https://hg.mozilla.org/mozilla-central/rev/881002d9a96b

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/38403cbd82e6
https://hg.mozilla.org/mozilla-central/rev/9ac10050264f
https://hg.mozilla.org/mozilla-central/rev/6a5aa84bce70
https://hg.mozilla.org/mozilla-central/rev/624ae1b1ac65