1767114 - Port bug 1766377 - Fix sign-compare warnings on Windows builds

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Rob Lemley [:rjl]]

-Wsign-compare (and -Werror) is now turned on for Windows builds via bug 1762484.

This is a particular gem:

    uint32_t dwordResult = -1;

https://searchfox.org/comm-central/rev/4a1e2097a493783193d61ab1e5dbb8e08d842381/mailnews/import/src/nsWMSettings.cpp#131

Comment 1

[Rob Lemley [:rjl]]

Attachment: WIP: Bug 1767114 - Disable sign-compare warnings on select files. rs=bustage-fix

Some of these could probably be cast easily enough, but as they say, "here there
be dragons". It's safer to selectively disable the warning-as-error on the
affected files pending closer examination.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6c21051a5d7f
Disable sign-compare warnings on select files. rs=bustage-fix

Comment 3

[Richard Marti (:Paenglab)]

I had to revert the change on mailnews/mapi/mapiDll/moz.build to get it built locally. Is where a setting to get it working?

I see now that the Windows localised builds have the same issue.

Comment 4

[Rob Lemley [:rjl]]

Looks like if you're not building with --enable-warnings-as-errors my fix didn't work.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c8476a107c16
Follow-up: Fix for builds not using --enable-warnings-as-errors. rs=bustage-fix

Comment 6

[Richard Marti (:Paenglab)]

Yes, works now. Thanks!

Comment 7

[Rachel Martin]

Attachment: 1767114-no-sign-compare.patch

No dragons.

Comment 8

[Rachel Martin]

We can't set "checkin-needed" here.

Comment 9

[Rob Lemley [:rjl]]

While reviewing, I noticed:

warning: comm/mail/components/search/wsenable/WSEnable.cpp:72:44 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long long'
warning: comm/mail/components/search/wsenable/WSEnable.cpp:108:46 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long long'

These don't result in an error because of AllowCompilerWarnings() in the moz.build file.

Comment 10

[Rachel Martin]

Attachment: 1767114-no-sign-compare.patch (v2)

OK, fixed those as well.

Comment 11

[Rob Lemley [:rjl]]

Attachment: 1767114-no-sign-compare.patch (v3)

Fix-up the moz.build file for WSEnable.exe.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5a58b0784f31
Fix no-sign-compare warnings. r=rjl

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f6d775b9b58d
Follow-up: Fix clang-format. rs=clang-format