1766470 - Bookmarks menu seperator context menu needs too precise mouse click

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

1. open the bookmarks menu
2. right click onto a separator line between to submenus

Actual results:

One of two menus pops up:

• If I clicked exactly, pixel-precisely with the mouse pointer tip onto the separation line, the context menu for the separator appears. This is useful e.g. to delete a separator.

• If I clicked at least by one pixel above or below the line, the context menu of the submenu above or below the separator appears.

Expected results:

When right-clicking close to the separator line (outside of the "grey areas" of the items above and below), the separator's menu should pop up.

Note that the "Manage bookmarks" and "Bookmarks sidebar" features allow to work around this issue. Right-clicking onto a separator there is no game of skill like directly in the bookmarks menu.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mark Banner (:standard8)]

We're wondering if this might be a regression from an earlier version, if so a regression range might be useful. However, it does indeed appear to be an issue, so I'm confirming the bug.

Comment 3

[Mark Banner (:standard8)]

The lack of height also makes it problematic to deal with moving separators around.

One issue is that the separators in the bookmarks menu are currently the same style as those in other menus, however they behave differently. Making more padding for the bookmarks menu would make them easier to work with, but potentially make them different to other menus.

Current suggestion is to make a patch to try and make consistent spacing (and maybe increase) above & below the separator and pass it to UX for feedback.

This would need testing on all platforms, and on the main menu bar, as well as the menus that appear for folders on the bookmarks toolbar.

Comment 4

[Dão Gottwald [:dao]]

Likely regressed by bug 1682522.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1682522

Comment 6

[Itiel]

(In reply to Dão Gottwald [:dao] from comment #4)

Likely regressed by bug 1682522.

I'm confused, bug 1714821 has fixed this issue, no?

Comment 7

[Dão Gottwald [:dao]]

Attachment: Bug 1766470 - Unify menuseparator implementation across platforms and increase hit area. r=emilio!,Itiel!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/342f7bb1e344
Unify menuseparator implementation across platforms and increase hit area. r=emilio,Itiel

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/342f7bb1e344

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1682522