1766523 - Implement new "Super Nova" icons in the Folder Pane

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Alessandro Castellani [:aleca]]

Implement the new icons in the Folder Pane for all accounts.
We need to explore and define if we want these icons to react to the density variations, or if the "compact" variant (16px) should be kept constant.

Comment 1

[[e-mail]]

Attachment: WIP: Bug 1766523 - Supernova folder pane icons

Comment 2

[[e-mail]]

Attachment: Bug 1766523 - Implement new icons in Folder Pane r=aleca

Comment 3

[[e-mail]]

Leaving open because we need to add a density variant for folder pane.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f66f2d68d50f
Implement new icons in Folder Pane r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug 1766523 - Show the folder icons correctly in all menulists. r=aleca

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: Screen Shot 2022-05-10 at 1.41.52 PM.png

The icons are incorrectly styled when the treechildren is selected but the tree doesn't have the focus.
This seems to happen only on macOS.
Since these are shadow DOM elements it's kinda tricky to find which style is affecting this in the inspector.
Richard, are you able to figure this out?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58ec8b3b50f9
Show the folder icons correctly in all menulists. r=aleca

Comment 8

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani [:aleca] from comment #6)

Created attachment 9275945 [details]
Screen Shot 2022-05-10 at 1.41.52 PM.png

The icons are incorrectly styled when the treechildren is selected but the tree doesn't have the focus.
This seems to happen only on macOS.
Since these are shadow DOM elements it's kinda tricky to find which style is affecting this in the inspector.
Richard, are you able to figure this out?

There are some places that are missed to set the correct fill/stroke. Found also an issue on Windows with dark theme. I'll look if I can fix the issues.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Bug 1766523 - Set the correct folder icon colors when selected or new message. r=aleca

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b23afa595fe0
Set the correct folder icon colors when selected or new message. r=aleca

Comment 11

[[e-mail]]

Attachment: Bug 1766523 - Implement new icons at touch density in folderpane r=aleca

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1fdf7eea4e4e
follow-up - Fix a broken CSS selector. rs=me

Comment 13

[Alessandro Castellani [:aleca]]

Attachment: Screen Shot 2022-05-15 at 10.02.18 PM.png

I just noticed that the indicator of "new" emails is cut off in normal and compact density.
I think it's a regression but I'm not sure it was caused by the new icon or any adjacent work we did here.
Anyway, it should be a very minor fix.

Comment 14

[Richard Marti (:Paenglab)]

Attachment: Windows-new.png

(In reply to Alessandro Castellani [:aleca] from comment #13)

Created attachment 9276626 [details]
Screen Shot 2022-05-15 at 10.02.18 PM.png

I just noticed that the indicator of "new" emails is cut off in normal and compact density.
I think it's a regression but I'm not sure it was caused by the new icon or any adjacent work we did here.
Anyway, it should be a very minor fix.

On which platform? On Windows with normal density it's okay. I think this is correlated with the treeitem height.

Comment 15

[Alessandro Castellani [:aleca]]

Sorry, forgot to mention. That's on macOS, no issues on Windows or Linux.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58daa42916da
Implement new icons at touch density in folderpane r=aleca

Comment 17

[Alessandro Castellani [:aleca]]

Anything else needed for this bug?

Comment 18

[[e-mail]]

(In reply to Alessandro Castellani [:aleca] from comment #17)

Anything else needed for this bug?

Not that I know of, unless I'm missing something.