1766604 - Support selecting multiple dictionaries in composition settings

Status: RESOLVED FIXED

(Thunderbird :: Preferences, enhancement)

Description

[Martin Giger [:freaktechnik]]

Bug 1761221 added support in the composition UI to handle multiple active dictionaries. We currently only allow selecting a single dictionary in the composition settings, but we now have all the infrastructure to allow multiple dictionaries to be enabled by default.

The main blocker for this is the UI element, since we need some way to select multiple entries. Sadly the XUL menulist element only supports a single active selection.

The dictionary selector in the spell checker popup used the same element. There we replaced it with a list of all installed dictionaries with checkboxes.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1766604 - Support selecting multiple dictionaries in composition preferences. r=freaktechnik

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6cc4a31f4ed3
Support selecting multiple dictionaries in composition preferences. r=freaktechnik

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9278778 [details]
Bug 1766604 - Support selecting multiple dictionaries in composition preferences. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): part of new feature
User impact if declined: can't select more than one dictionary by default
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): we haven't noticed any problems on c-c. Not a huge risk, but there something unknown lurking.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9278778 [details]
Bug 1766604 - Support selecting multiple dictionaries in composition preferences. r=freaktechnik

[Triage Comment]
Approved for esr102. But I'm not sure how to interpret the following comment

(In reply to Magnus Melin [:mkmelin] from comment #3)

...
Risk to taking this patch (and alternatives if risky): ... there something unknown lurking.

Is this just speculation? Or is there something specific found during testing that we should be looking for?

Comment 5

[Magnus Melin [:mkmelin]]

Nothing in particular I know about. Just an area that seems somewhat brittle + it's a new feature. It would only affect spell checking related things though.

Comment 6

[Martin Giger [:freaktechnik]]

It does seem like a bug was found that essentially means selecting multiple dictionaries doesn't work correctly. See Bug 1775376 (also applies to selecting multiple dictionaries in preferences from what I can see)

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.0:
https://hg.mozilla.org/releases/comm-esr102/rev/f0f7a0e0df83

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d821feda2cc1
follow-up - backout of accesskey removal. rs=backout

Comment 9

[b1]

You should push this change to ESR 102 since without it, the structure of the string doesn't match and the translation isn't used. The localisations have the access key, examples:
https://searchfox.org/l10n/rev/df0c315d14df2489bb47a696963390fb8781af72/de/mail/messenger/preferences/preferences.ftl#553
https://searchfox.org/l10n/rev/df0c315d14df2489bb47a696963390fb8781af72/fr/mail/messenger/preferences/preferences.ftl#552

Comment 10

[b1]

That said, some locales don't have it:
https://searchfox.org/l10n/rev/df0c315d14df2489bb47a696963390fb8781af72/ja-JP-mac/mail/messenger/preferences/preferences.ftl#424
So the only way to fix this is to create a new string name :-(

Comment 11

[b1]

On second thought: Maybe just adding it again will eventually cause the locales that don't have it, like Japanese, to add it again.

Comment 12

[Magnus Melin [:mkmelin]]

Apparently only pl and Japanese do not have the accesskey.

(In reply to b1 from comment #9)

You should push this change to ESR 102 since without it, the structure of the string doesn't match and the translation isn't used.

If this is a problem for the scripts that seems like something we should see if it can be fixed.
For Fluent itself, I don't think that should be a problem?

Comment 13

[b1]

Attachment: language.png

This is the effect using
http://ftp.mozilla.org/pub/thunderbird/candidates/102.2.0-candidates/build2/win64/es-AR/

Comment 14

[Magnus Melin [:mkmelin]]

language-popup-label is missing from the es-AR localization file. I assume it's the merging script that nuked it.

Comment 15

[b1]

Really?
https://searchfox.org/l10n/rev/3bc30f6c520bb2d16dd127fdc23c163ff09d3f6b/es-AR/mail/messenger/preferences/preferences.ftl#550

It's more likely that the string is rejected altogether due to the difference in structure from:
https://searchfox.org/comm-esr102/rev/b0233f0ef4e5f439d7ff2c7eebf7c1cd93dfcd70/mail/locales/en-US/messenger/preferences/preferences.ftl#542

That's why we suggested to uplift https://hg.mozilla.org/comm-central/rev/d821feda2cc1. If comment #12 is correct, only ja and pl will then need to adjust.

Comment 16

[Magnus Melin [:mkmelin]]

language-popup-label is not there if you download the build2 zip file and take a look at the es-AR preferences.ftl. There's a blank hole of a few lines where it should be.

Comment 17

[b1]

Exactly. The XPI and the repackaged installer are missing the string since the repacking process rejects it due to the different structure. All will be fine if you do the uplift we suggested (apart from ja and pl).

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 102.2.0:
https://hg.mozilla.org/releases/comm-esr102/rev/597f8a904021