1761221 - Support multiple active spell checking dictionaries

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, enhancement)

Description

[Martin Giger [:freaktechnik]]

With bug 1402822 landed we can now have multiple dictionaries active. The initial patch to port the interface changes didn't touch the UI. There's a couple of complications related to this: we currently set the lang tag of the document to the spell checked language as far as I can tell. We would probably want to set the tag to the empty string value, which means we explicitly don't know which single language the content is. This also affects the chat message editor.
Further, we use the spellchecker.dictionary pref to select a single dictionary when initializing the window. This should probably be migrated to a preference that supports storing multiple selected dictionaries.
And we of course have to allow our UIs, the inline spellchecker dictionary selector and the dedicated spell checker window, to select more than one dictionary.

We might also need the changes that might happen in bug 69687, hard to tell.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1761221 - Fully support selecting multiple dictionaries in message composition. r=aleca

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1761221 - Persist active dictionaries for consistent state with disabled inline checking. r=aleca

Depends on D144555

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d6f16d4857ed
Fully support selecting multiple dictionaries in message composition. r=aleca

Comment 4

[newsfan]

This is fantastic new functionality, guys. Finally we can write in two or more languages in the one e-mail. Tested a bit in Daily. Setting dictionaries in the subject, body, status bar and spelling button all working and persisted nicely when switching between windows.