1766997 - [Windows] Scrollbars are wrongly displayed inside the default "ECO" spotlights

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Notes]:

• This issue is NOT reproducible on Windows 11 x64, macOS 11.6, and Linux Mint 20.2 x64.

[Affected versions]:

• Firefox Release 99.0.1 - Build ID: 20220411174855
• Firefox Beta 100.0 - Build ID: 20220428192727
• Firefox Nightly 101.0a1 - Build ID: 20220428214715

[Affected Platforms]:

• Windows 10 x64
• Windows 8.1 x64

[Prerequisites]:

• Have a Firefox profile with the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref set to "true" in the "about:config" page.

[Steps to reproduce]:

1. Open the browser using the profile from the prerequisites.
2. Navigate to the "about:newtab#asrouter" page.
3. Search for the "peace-of-mind-a-rollout-global" and click the "Show" button.
4. Observe the spotlight.

[Expected result]:

• The "ECO" spotlight is successfully displayed and all the elements are visible.

[Actual result]:

• Scrollbars are wrongly displayed inside the default "ECO" spotlight.

[Regression Window]:

• This issue is not reproducible with the Firefox Release 98.0.2 version. Considering this using the Mozregression tool I have managed to find the following regression window:
  Last good revision: 1f27d80f3ad1b439bfb1fc3d359306de32ffbfe4
  First bad revision: 626b4df4561e97285ab4b018769e636fc1feea36
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1f27d80f3ad1b439bfb1fc3d359306de32ffbfe4&tochange=626b4df4561e97285ab4b018769e636fc1feea36

From the pushlog it seems that bug 1758187 has caused this regression.

@Ed, could you please take a look over this issue?

[Additional Notes]:

• This issue is also reproducible with the "better-internet-c-rollout-global" spotlight.
• Attached a screen recording of the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1758187

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

I've seen this at least once on a local Mac build, though I can't reproduce it now.

Comment 3

[Ed Lee :Mardak]

mcoman, could you test the fix (changing title size from 22px to 23px) with remote settings "stage (preview)" for both messages with various platforms/locales/etc?

https://settings.stage.mozaws.net/v1/buckets/main-preview/collections/cfr/records/better-internet-c-rollout-global
https://settings.stage.mozaws.net/v1/buckets/main-preview/collections/cfr/records/peace-of-mind-a-rollout-global

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have tested this issue with the latest Firefox Beta (100.0 Build ID - 20220428192727) installed on Windows 10 x64 and Windows 8.1 x64. Here are the results:

• On the en-US, DE, FR, "RO", RU, zh-CN, ES, and pt-BR Firefox locales both messages are correctly displayed without scrollbars.
• On the IT Firefox locale scrollbars are still displayed inside the "better-internet-c-rollout-global" message, but the "peace-of-mind-a-rollout-global" one is correctly displayed.
• On the AR Firefox locale both messages are still affected and scrollbars are displayed.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1758187

Comment 6

[Ed Lee :Mardak]

Reduced font size to 20px to not show scrollbars for various locales including it

https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/cfr/records/better-internet-c-rollout-global
https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/cfr/records/peace-of-mind-a-rollout-global

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 102.0a1 it (Build ID: 20220510213954), Firefox Beta 101.0b5 en-US, de, ru (Build ID: 20220510144626), Firefox Release 100.0 es-ES, fr, ja, zh-CN, ro (Build ID: 20220428192727) on Windows 10 x64, macOS 12.3.1, and Ubuntu 20.04 x64.

• The scrollbars are no longer displayed on the "better-internet-c-rollout-global" and "peace-of-mind-a-rollout-global" messages.

However, while verifying this issue, I observed that it is still reproducible on ar locale, so I logged a new one for this (Bug 1768849).
Considering these, I’m marking this issue as Verified Fixed.