1768675 - Add PiP captions/subtitles support for youtube-no-cookie.com videos

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[kpatenio]

While we may have PiP captions/subtitles support for YouTube.com, our current YouTube video wrapper does not work with YouTube videos that are embedded via youtube-no-cookie.com. A couple places that use no-cookie include khanacademy.org and YouTube videos loaded within DuckDuckGo.

Short STR:

1. Watch either video linked above (for duckduckgo, be sure to watch the video within duckduckgo)
2. Enable captions and pip window

Expected result: subtitles/captions should appear on pip window
Actual result: there are no subtitles/captions on the pip window

I believe this requires either: a new video wrapper for youtube-no-cookie.com, or simply adding youtube-no-cookie.com as a new URL pattern here.

Comment 1

[Yi Xiong Wong]

Hello, I'm interested in working on this bug. I think I have an idea that would work for embeds.

Comment 2

[Yi Xiong Wong]

Attachment: Bug 1768675 - Use wrapper for embedded Youtube videos. r=#pip-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6edb3047240
Use wrapper for embedded Youtube videos. r=pip-reviewers,kpatenio

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e6edb3047240