Closed
Bug 1768675
Opened 2 years ago
Closed 2 years ago
Add PiP captions/subtitles support for youtube-no-cookie.com videos
Categories
(Toolkit :: Picture-in-Picture, enhancement, P3)
Toolkit
Picture-in-Picture
Tracking
()
RESOLVED
FIXED
103 Branch
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: kpatenio, Assigned: johnmax2468)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
While we may have PiP captions/subtitles support for YouTube.com, our current YouTube video wrapper does not work with YouTube videos that are embedded via youtube-no-cookie.com. A couple places that use no-cookie include khanacademy.org and YouTube videos loaded within DuckDuckGo.
Short STR:
- Watch either video linked above (for duckduckgo, be sure to watch the video within duckduckgo)
- Enable captions and pip window
Expected result: subtitles/captions should appear on pip window
Actual result: there are no subtitles/captions on the pip window
I believe this requires either: a new video wrapper for youtube-no-cookie.com, or simply adding youtube-no-cookie.com as a new URL pattern here.
|
Assignee | |
Comment 1•2 years ago
|
||
Hello, I'm interested in working on this bug. I think I have an idea that would work for embeds.
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → johnmax2468
Status: NEW → ASSIGNED
|
|
||
Updated•2 years ago
|
Attachment #9279816 -
Attachment description: Bug 1768675 - Use wrappers for embedded videos. r=#pip-reviewers → Bug 1768675 - Use wrapper for embedded Youtube videos. r=#pip-reviewers
Pushed by kpatenio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6edb3047240 Use wrapper for embedded Youtube videos. r=pip-reviewers,kpatenio
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•