Closed
Bug 1771550
Opened 2 years ago
Closed 2 years ago
PiP Subtitles Support for Khan Academy
Categories
(Toolkit :: Picture-in-Picture, enhancement, P3)
Toolkit
Picture-in-Picture
Tracking
()
RESOLVED
FIXED
People
(Reporter: asafko, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
Adding a new site-specific wrapper how-to.
Current Behavior
- Navigate to https://www.khanacademy.org/
- Play a video
- Enable subtitles in player
- Open video in PiP player
Actual results:
No subtitles are displayed in the PiP window
Expected results:
Subtitles are displayed in the PiP window
Updated•2 years ago
|
Keywords: good-first-bug
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → eddiebrace
Status: NEW → ASSIGNED
Comment 2•2 years ago
|
||
The following patch is waiting for review from an inactive reviewer:
ID | Title | Author | Reviewer Status |
---|---|---|---|
D148668 | Bug 1771550 - Add PiP subtitles support for khanacademy.org r=mconley | eddiebrace | mconley: Resigned from review |
:eddiebrace, could you please find another reviewer?
For more information, please visit auto_nag documentation.
Flags: needinfo?(eddiebrace)
Comment hidden (off-topic) |
Comment 4•2 years ago
|
||
Sorry, there was a problem with the detection of inactive users. I'm reverting the change.
Assignee: nobody → eddiebrace
Status: NEW → ASSIGNED
Comment 5•2 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Assignee: eddiebrace → nobody
Status: ASSIGNED → NEW
The fix for Bug 1768675 should already provide support for PiP captions on Khan Academy. I want to say that this bug can be marked as closed.
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(eddiebrace)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•