1768870 - Add lazy ESM loading function to ChromeUtils

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Comment 1

[Tooru Fujisawa [:arai]]

ESM component needs the equivalent of ChromeUtils.defineModuleGetter and/or XPCOMUtils.defineLazyModuleGetters

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1768870 - Part 1: Rename JSM-specific module_getter functions. r?kmag!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1768870 - Part 2: Add ChromeUtils.defineESModuleGetters. r?kmag!

Depends on D146211

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe708d13cc1d
Part 1: Rename JSM-specific module_getter functions. r=kmag
https://hg.mozilla.org/integration/autoland/rev/f85393f988a8
Part 2: Add ChromeUtils.defineESModuleGetters. r=kmag

Comment 5

[Sandor Molnar[:smolnar]]

Backed out 9 changesets (bug 1769002, bug 1768870, bug 1771097, bug 1771092, bug 1768819) for causing lint failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cc95bf5ad7c5e9bca85278b59608cc9190fdc27d

Push with failures

Failure log lint black

Failure log es lint

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestProcessActorChild.sys.mjs:9:1 | Prefer default export. (import/prefer-default-export)
EST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestWindowChild.sys.mjs:11:1 | Prefer default export. (import/prefer-default-export)
[task 2022-06-16T17:07:08.660Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestWindowParent.sys.mjs:9:1 | Prefer default export. (import/prefer-default-export)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f53760c5637
Part 1: Rename JSM-specific module_getter functions. r=kmag
https://hg.mozilla.org/integration/autoland/rev/960f0aee97d5
Part 2: Add ChromeUtils.defineESModuleGetters. r=kmag

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

Backed out together with Bug 1771092 , for causing mochitest failures on browser_sendQuery.js

Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | dom/ipc/tests/JSProcessActor/browser_sendQuery.js | Error should have the correct stack - Got "receiveMessage@resource://testing-common/TestProcessActorChild.sys.mjs:32:31\n", expected "receiveMessage@resource://testing-common/TestProcessActorChild.sys.mjs:31:31\n"

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5ec9e74ed3e
Part 1: Rename JSM-specific module_getter functions. r=kmag
https://hg.mozilla.org/integration/autoland/rev/d1ce095c6e67
Part 2: Add ChromeUtils.defineESModuleGetters. r=kmag

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b5ec9e74ed3e
https://hg.mozilla.org/mozilla-central/rev/d1ce095c6e67