Closed Bug 1771097 Opened 2 years ago Closed 2 years ago

Add ESLint rule for lazy getter object name

Categories

(Core :: XPConnect, task)

task

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug 1768870 will add lazy getter for ESM, and it's better applying an ESLint rule to standardize the lazy object name "lazy"

Assignee: nobody → arai.unmht
Attachment #9278300 - Attachment description: WIP: Bug 1771097 - Add ESLint rule for ChromeUtils.defineESMGetters lazy object name. r?Standard8! → Bug 1771097 - Add ESLint rule for ChromeUtils.defineESMGetters lazy object name. r?Standard8!
Status: NEW → ASSIGNED
Attachment #9278300 - Attachment description: Bug 1771097 - Add ESLint rule for ChromeUtils.defineESMGetters lazy object name. r?Standard8! → Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r?Standard8!
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/c64e6c1fbfe7
Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8

Backed out 9 changesets (bug 1769002, bug 1768870, bug 1771097, bug 1771092, bug 1768819) for causing lint failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cc95bf5ad7c5e9bca85278b59608cc9190fdc27d

Push with failures

Failure log lint black

Failure log es lint

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestProcessActorChild.sys.mjs:9:1 | Prefer default export. (import/prefer-default-export)
EST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestWindowChild.sys.mjs:11:1 | Prefer default export. (import/prefer-default-export)
[task 2022-06-16T17:07:08.660Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestWindowParent.sys.mjs:9:1 | Prefer default export. (import/prefer-default-export)
Flags: needinfo?(arai.unmht)
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/6205d3e2c666
Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8

Backed out together with Bug 1771092 , for causing mochitest failures on browser_sendQuery.js

Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | dom/ipc/tests/JSProcessActor/browser_sendQuery.js | Error should have the correct stack - Got "receiveMessage@resource://testing-common/TestProcessActorChild.sys.mjs:32:31\n", expected "receiveMessage@resource://testing-common/TestProcessActorChild.sys.mjs:31:31\n"

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/b750825ae3d0
Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: