1771092 - Support ESM in ChromeUtils.registerWindowActor

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task)

Description

[Tooru Fujisawa [:arai]]

ChromeUtils.registerWindowActor receives the URL of JSM as moduleURI property.
To support ESM, it needs:

• Decide the way to pass ESM URI
• Support loading module inside it

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1771092 - Part 1: Add esModuleURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r?kmag!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1771092 - Part 2: Add tests for process/window actors with ESM. r?kmag!

Depends on D147422

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1771092 - Part 3: Add tests JSM and ESM URIs combination. r?kmag!

Depends on D147587

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a49f754ca73f
Part 1: Add esModuleURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r=kmag
https://hg.mozilla.org/integration/autoland/rev/25b43856bc00
Part 2: Add tests for process/window actors with ESM. r=kmag
https://hg.mozilla.org/integration/autoland/rev/f0537d333adc
Part 3: Add tests JSM and ESM URIs combination. r=kmag

Comment 5

[Tooru Fujisawa [:arai]]

conflicted with bug 1773472.
will address in bug 1774647

Comment 6

[Tooru Fujisawa [:arai]]

(bug 1769002 comment #4)

Backed out 9 changesets (bug 1769002, bug 1768870, bug 1771097, bug 1771092, bug 1768819) for causing lint failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cc95bf5ad7c5e9bca85278b59608cc9190fdc27d

Push with failures

Failure log lint black

Failure log es lint

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestProcessActorChild.sys.mjs:9:1 | Prefer default export. (import/prefer-default-export)
EST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestWindowChild.sys.mjs:11:1 | Prefer default export. (import/prefer-default-export)
[task 2022-06-16T17:07:08.660Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestWindowParent.sys.mjs:9:1 | Prefer default export. (import/prefer-default-export)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/072323bc72cc
Part 1: Add esModuleURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r=kmag
https://hg.mozilla.org/integration/autoland/rev/f4e27a35c83c
Part 2: Add tests for process/window actors with ESM. r=kmag
https://hg.mozilla.org/integration/autoland/rev/8a4d712f819a
Part 3: Add tests JSM and ESM URIs combination. r=kmag

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing mochitest failures on browser_sendQuery.js

Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | dom/ipc/tests/JSProcessActor/browser_sendQuery.js | Error should have the correct stack - Got "receiveMessage@resource://testing-common/TestProcessActorChild.sys.mjs:32:31\n", expected "receiveMessage@resource://testing-common/TestProcessActorChild.sys.mjs:31:31\n"

Comment 9

[Tooru Fujisawa [:arai]]

so, apparently we cannot reorder this patch and bug 1774647 cleanly.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46e082c3f939
Part 1: Add esModuleURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r=kmag
https://hg.mozilla.org/integration/autoland/rev/31279c78d127
Part 2: Add tests for process/window actors with ESM. r=kmag
https://hg.mozilla.org/integration/autoland/rev/b738d1f76f5d
Part 3: Add tests JSM and ESM URIs combination. r=kmag

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/46e082c3f939
https://hg.mozilla.org/mozilla-central/rev/31279c78d127
https://hg.mozilla.org/mozilla-central/rev/b738d1f76f5d