1770545 - PiP subtitles support for Nebula

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P5)

Description

[Yi Xiong Wong]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

1. Navigate to Nebula
2. Play a video (a paid account is required for this)
3. Enable subtitles in player
4. Open video in PiP player

Actual results:
No subtitles are displayed in PiP window

Expected results:
Subtitles are displayed in PiP window

Comment 1

[Ania]

Hi Wong,
We will review and accept patches for site-specific adapters for subtitles, but unless the website is one of the top-voted ones in this poll, Mozilla team will not be working on adding them.

Comment 2

[Yi Xiong Wong]

Yes, I have a patch ready, it's just that moz-phab is broken for me right now until this bug gets solved: https://bugzilla.mozilla.org/show_bug.cgi?id=1770791

Comment 3

[Yi Xiong Wong]

Attachment: Bug 1770545 - Add video wrapper for Nebula subtitles. r=#pip-reviewers

Comment 4

[Ania]

Awesome, thank you so much, Wong!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3207369cabf5
Add video wrapper for Nebula subtitles. r=pip-reviewers,kpatenio

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3207369cabf5