Closed Bug 1770545 Opened 10 months ago Closed 10 months ago

PiP subtitles support for Nebula

Categories

(Toolkit :: Picture-in-Picture, enhancement, P5)

Product:
Toolkit
Component:
Picture-in-Picture
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: johnmax2468, Assigned: johnmax2468)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1770545 - Add video wrapper for Nebula subtitles. r=#pip-reviewers
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

  1. Navigate to Nebula
  2. Play a video (a paid account is required for this)
  3. Enable subtitles in player
  4. Open video in PiP player

Actual results:
No subtitles are displayed in PiP window

Expected results:
Subtitles are displayed in PiP window

Depends on: 1765604
Blocks: 1765604
No longer depends on: 1765604
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P5

Hi Wong,
We will review and accept patches for site-specific adapters for subtitles, but unless the website is one of the top-voted ones in this poll, Mozilla team will not be working on adding them.

Yes, I have a patch ready, it's just that moz-phab is broken for me right now until this bug gets solved: https://bugzilla.mozilla.org/show_bug.cgi?id=1770791

Assignee: nobody → johnmax2468
Status: NEW → ASSIGNED

Awesome, thank you so much, Wong!

See Also: → 1762230
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3207369cabf5
Add video wrapper for Nebula subtitles. r=pip-reviewers,kpatenio

https://hg.mozilla.org/mozilla-central/rev/3207369cabf5

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.