1770869 - remove nsILocalCertService and nsISSLSocketControl.clientCert

Status: RESOLVED FIXED

(Core :: Security: PSM, task, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

nsILocalCertService is only used in tests at the moment, and its purpose can be served more simply by importing a certificate and private key (it was used in flyweb, but that was removed in Firefox 59 (bug 1374574)).
nsISSLSocketControl.clientCert was essentially only used in WebIDE, but that was removed in Firefox 71 (bug 1539462).

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: Bug 1770869 - remove unused client certificate authentication for remote devtools r?ochameau

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: Bug 1770869 - remove nsILocalCertService and implementation r?jschanck!,pbz!,kershaw!

Depends on D147121

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: Bug 1770869 - remove nsISSLSocketControl.clientCert r?jschanck

This field isn't used any longer and removing it will make future changes
eaiser.

Depends on D147122

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a138d047be1
remove unused client certificate authentication for remote devtools r=ochameau
https://hg.mozilla.org/integration/autoland/rev/149d04a209b6
remove nsILocalCertService and implementation r=necko-reviewers,jschanck,pbz,kershaw
https://hg.mozilla.org/integration/autoland/rev/5c95392b800d
remove nsISSLSocketControl.clientCert r=jschanck,necko-reviewers,kershaw

Comment 5

[Atila Butkovits]

Backed out for causing xpcshell failures at test_tls_server.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/014c8a645401de7df8cef2cfb4f1665d2d38cba6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=aYlr6o5zTV6NWx82HhCOwA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5c95392b800d834a36bcef3f6a5015d671331067

Failure log: https://treeherder.mozilla.org/logviewer?job_id=379947483&repo=autoland&lineNumber=6196

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7c44ddd5e6f
remove unused client certificate authentication for remote devtools r=ochameau
https://hg.mozilla.org/integration/autoland/rev/43f192c53f08
remove nsILocalCertService and implementation r=necko-reviewers,jschanck,pbz,kershaw
https://hg.mozilla.org/integration/autoland/rev/1dbd6821128b
remove nsISSLSocketControl.clientCert r=jschanck,necko-reviewers,kershaw

Comment 7

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/d7c44ddd5e6f
https://hg.mozilla.org/mozilla-central/rev/43f192c53f08
https://hg.mozilla.org/mozilla-central/rev/1dbd6821128b