1771452 - Enable ipc/glue/test/browser/test_utility_audio_o*.html on Android/Isolated Process

Status: RESOLVED FIXED

(Core :: IPC, task, P5)

Description

[:gerard-majax]

+++ This bug was initially created as a clone of Bug #1771416 +++

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 2

[:gerard-majax]

Current status is that things are running, decoding a few frame, then stalling on the media side. Looks like remoting cubeb is still to be done and this is why.

Comment 3

[:gerard-majax]

Sharing a patch that should be enough once the remoting of cubeb is done

Comment 4

[:gerard-majax]

Attachment: Bug 1771452 - Enable Utility process for Android with Isolated Process r?padenot!

Comment 5

[:gerard-majax]

Attachment: utility_android_isolated.log

Comment 6

[:gerard-majax]

(In reply to :gerard-majax [PTO 01/08/2023-10/09/2023] from comment #3)

Sharing a patch that should be enough once the remoting of cubeb is done

Of course ac_add_options --enable-isolated-process at build time.

Comment 7

[:gerard-majax]

So while the test is still failing, it looks like an isolated process build of the geckoview example is able to play audio through utility process

Comment 8

[:gerard-majax]

Olivia, checking with your patch I can see the changes:

• without https://treeherder.mozilla.org/jobs?repo=try&author=alissy%40mozilla.com&selectedTaskRun=DWrx_qw4SXSl__2W9NYDFA.0
• with https://treeherder.mozilla.org/jobs?repo=try&author=alissy%40mozilla.com&selectedTaskRun=EEutT52SRl-iBBMbyELN4w.0

It looks like the Utility process part works now and we are just stuck on the AAC decoder not working?

Comment 9

[Olivia Hall [:olivia]]

It looks like the Utility process part works now and we are just stuck on the AAC decoder not working?

Looks like a decoder issue is all that remains to me too! In the patch with changes with, the remaining failures logs are:

04-10 05:53:35.074  3604  3850 I Gecko   : [Child 3604, MediaSupervisor #2] WARNING: Error constructing decoders: file /builds/worker/checkouts/gecko/dom/media/MediaFormatReader.cpp:446
04-10 05:53:35.074  3604  3850 I Gecko   : [Child 3604, MediaSupervisor #2] WARNING: NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - Error no decoder found for audio/mp4a-latm: file /builds/worker/checkouts/gecko/dom/media/MediaFormatReader.cpp:1876
04-10 05:53:35.074  3604  3774 I Gecko   : [Child 3604, MediaDecoderStateMachine #1] WARNING: Decoder=7f55eeb1d000 Decode error: NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - Error no decoder found for audio/mp4a-latm: file /builds/worker/checkouts/gecko/dom/media/MediaDecoderStateMachineBase.cpp:168
04-10 05:53:35.079  3604  3619 W Web Content: [JavaScript Warning: "Media resource https://example.com/browser/ipc/glue/test/browser/small-shot.m4a could not be decoded." {file: "http://mochi.test:8888/tests/ipc/glue/test/browser/test_utility_audio_on.html" line: 0}]
04-10 05:53:35.085  3604  3619 W Web Content: [JavaScript Warning: "This error message will be blank when privacy.resistFingerprinting = true.  If it is really necessary, please add it to the whitelist in MediaError::GetMessage: Failed to decode media" {file: "http://mochi.test:8888/tests/ipc/glue/test/browser/head.js" line: 388}]

Great news that the test is now getting farther than the audio_flinger issue before.

Thanks for looking at these tests and preparing a patch!

Comment 10

[:gerard-majax]

(In reply to Olivia Hall [:olivia] from comment #9)

It looks like the Utility process part works now and we are just stuck on the AAC decoder not working?

Looks like a decoder issue is all that remains to me too! In the patch with changes with, the remaining failures logs are:

04-10 05:53:35.074  3604  3850 I Gecko   : [Child 3604, MediaSupervisor #2] WARNING: Error constructing decoders: file /builds/worker/checkouts/gecko/dom/media/MediaFormatReader.cpp:446
04-10 05:53:35.074  3604  3850 I Gecko   : [Child 3604, MediaSupervisor #2] WARNING: NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - Error no decoder found for audio/mp4a-latm: file /builds/worker/checkouts/gecko/dom/media/MediaFormatReader.cpp:1876
04-10 05:53:35.074  3604  3774 I Gecko   : [Child 3604, MediaDecoderStateMachine #1] WARNING: Decoder=7f55eeb1d000 Decode error: NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - Error no decoder found for audio/mp4a-latm: file /builds/worker/checkouts/gecko/dom/media/MediaDecoderStateMachineBase.cpp:168
04-10 05:53:35.079  3604  3619 W Web Content: [JavaScript Warning: "Media resource https://example.com/browser/ipc/glue/test/browser/small-shot.m4a could not be decoded." {file: "http://mochi.test:8888/tests/ipc/glue/test/browser/test_utility_audio_on.html" line: 0}]
04-10 05:53:35.085  3604  3619 W Web Content: [JavaScript Warning: "This error message will be blank when privacy.resistFingerprinting = true.  If it is really necessary, please add it to the whitelist in MediaError::GetMessage: Failed to decode media" {file: "http://mochi.test:8888/tests/ipc/glue/test/browser/head.js" line: 388}]

Great news that the test is now getting farther than the audio_flinger issue before.

Thanks for looking at these tests and preparing a patch!

Yes and it will be taken care of in bug 1934009 so we dont really have to care about it now, the rest can move forward, I'm splitting the tests in https://treeherder.mozilla.org/jobs?repo=try&revision=11260207fbb5e2b27cca270deb152c7384ab6f4c

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb1915bbbec9
Enable Utility process for Android with Isolated Process r=padenot

Comment 12

[Atila Butkovits]

Backed out for causing failures at test_android_audio_off.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/94eca50fe929a175586b5950577f37b64c6b762d

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=BEY3eczCTVG7xo-KoF1Ecw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=590f9e15d4f5007c75250d7026de93e8e7fc3815

Failure log: https://treeherder.mozilla.org/logviewer?job_id=503328526&repo=autoland&lineNumber=7400

Comment 13

[:gerard-majax]

meh, run-if gets overwritten?

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e916e43dce04
Enable Utility process for Android with Isolated Process r=padenot

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e916e43dce04