1700243 - Cubeb remoting, sandboxing support on Android needed

Status: ASSIGNED

(Core :: Audio/Video: cubeb, task)

Description

[[:owlish] 🦉 PST]

We are currently working on sandboxing Fenix, and we need cubeb to be able to handle sandboxing on Android as well.

It appears remoting has to work for sandboxing. Currently, when I naively try to define MOZ_CUBEB_REMOTING in [1] and remove this condition in [2], I get a linker error undefined hidden symbol: audioipc_client_init.

[1] https://searchfox.org/mozilla-central/rev/36f79bed679ad7ec46f7cd05868a8f6dc823e1be/dom/media/CubebUtils.cpp#63
[2] https://searchfox.org/mozilla-central/source/toolkit/library/rust/gkrust-features.mozbuild#33

Comment 1

[Chris Peterson [:cpeterson]]

cubeb sandboxing is a prerequisite for Android process sandboxing, but it's not a blocker for shipping Android Fission.

Comment 2

[Jim Mathies [:jimm]]

update - The new audio ipc remoting work landed and is enabled by default for testing.

Comment 3

[[:owlish] 🦉 PST]

That's great news! So, to make sure we are using remoted cubeb when running tests locally, all we need to do is to run our tests on a fresh rebase and fresh bootstrap, is that correct? We don't need to change anything here for Android?

Comment 4

[Jim Mathies [:jimm]]

re-routing that question to Mathew for confirmation but yes, it's on by default in mc so should get picked up for test runs.

Comment 5

[:gerard-majax]

All of the testing I could perform would suggest it works on mach run but it does not work on mochitests, but I believe I hve pinged :kinetic enough already :)