Open Bug 1709948 Opened 4 years ago Updated 4 months ago

[meta] Fix mochitests for isolated process

Categories

(GeckoView :: General, task, P2)

Unspecified
All
task

Tracking

(Not tracked)

People

(Reporter: owlish, Unassigned)

References

(Depends on 3 open bugs, Blocks 2 open bugs)

Details

(Keywords: meta, Whiteboard: [sandboxing] [geckoview:2022q3] [fxdroid] [geckoview] )

Affected tests:

  • mochitest-plain M()
  • mochitest-plain-gpu M(gpu)
  • mochitest-media M(mda)
  • mochitest-media, socketprocess variant M-spi(mda)

Once fixed, these should be enabled in automation (i.e. have the same tier in sandboxed builds as in non-sandboxed builds of the same type)

Severity: -- → S3
Priority: -- → P2
Whiteboard: [geckoview:m91?]
Whiteboard: [geckoview:m91?]
Whiteboard: [geckoview:2022q3?]
Whiteboard: [geckoview:2022q3?] → [sandboxing] [geckoview:2022q3]

Moving isolated process bugs to the new GeckoView::Sandboxing component.

Component: General → Sandboxing
Assignee: nobody → ohall
Assignee: ohall → nobody
Depends on: 1706656, 1700243

Overview of mochitests

M-nofis(1)

Test Error Call Possible Bug
docshell/test/navigation/test_blockBFCache.html AudioFlinger not published - 1700243
dom/worklet/tests/test_audioWorklet_insecureContext.html AudioFlinger not published likely new AudioContext() 1700243

M-nofis(2)

Test Error Call Possible Bug
dom/canvas/test/test_capture.html AudioFlinger not published captureStream() 1700243
dom/events/test/test_all_synthetic_events.html AudioFlinger not published likely new AudioContext() 1700243
toolkit/content/tests/widgets/test_bug898940.html AudioFlinger not published likely audio.play(); 1700243
toolkit/content/tests/widgets/test_videocontrols_audio.html AudioFlinger not published - 1700243
toolkit/content/tests/widgets/test_videocontrols_error.html Passed Locally (?) - -
dom/origin-trials/tests/mochitest/test_expired_token.html AudioFlinger not published likely new AudioContext() 1700243

M-nofis(3)

Test Error Call Possible Bug
dom/canvas/test/crossorigin/test_canvas2d_crossorigin.html AudioFlinger not published captureStream() 1700243

M-nofis(gpu)

Test Error Call Possible Bug
dom/canvas/test/crossorigin/test_video_crossorigin.html AudioFlinger not published captureStream() 1700243

M-nofis(mda)

Test Error Call Possible Bug
dom/media/mediasource/test/test_AVC3_mp4.html Waiting for service SurfaceFlinger - 1706656
dom/media/test/test_VideoPlaybackQuality.html Waiting for service SurfaceFlinger - 1706656
dom/media/test/test_imagecapture.html AudioFlinger not published - 1700243
dom/media/test/test_bug1113600.html AudioFlinger not published - 1700243
dom/media/test/test_bug1242338.html Waiting for service SurfaceFlinger - 1706656
dom/media/test/test_mediacapabilities_resistfingerprinting.html Waiting for service SurfaceFlinger - 1706656
dom/media/test/test_mediarecorder_avoid_recursion.html AudioFlinger not published - 1700243
dom/media/test/test_seek_duration.html Waiting for service SurfaceFlinger - 1706656

M-spi-nofis(mda)

Test
dom/media/mediasource/test/test_AVC3_mp4.html
dom/media/test/test_VideoPlaybackQuality.html
dom/media/test/test_imagecapture.html
dom/media/test/test_bug1113600.html
dom/media/test/test_bug1242338.html
dom/media/test/test_mediacapabilities_resistfingerprinting.html
dom/media/test/test_mediarecorder_avoid_recursion.html
dom/media/test/test_seek_duration.html

Try used to build list + local runs.

Depends on: 1810736

Tasks should have severity N/A.

Severity: S3 → N/A
Blocks: 1835146
Blocks: 1771452
Duplicate of this bug: 1882927
Depends on: 1895581
Component: Sandboxing → General
Duplicate of this bug: 1900519

Many tests are still failing - I thought some might be fixed due to the cubeb updates.

Non-comprehensive list of failures:

  • dom/canvas/test/test_capture.html
  • docshell/test/navigation/test_blockBFCache.html
  • dom/canvas/test/crossorigin/test_canvas2d_crossorigin.html
  • dom/canvas/test/crossorigin/test_video_crossorigin.html
  • dom/media/test/test_complete_length.html

It seems like some of the failures also bring down the test harness, so there is the possibility that more tests failing as well. It does seem like less failures than listed in the original report, so maybe we have some improvement or at least new metadata.

Flags: needinfo?(ohall)
Duplicate of this bug: 1944812
Duplicate of this bug: 1809508
Depends on: 1698214
Whiteboard: [sandboxing] [geckoview:2022q3] → [sandboxing] [geckoview:2022q3] [fxdroid] [geckoview]

Sending another try up since bug 1698214 has unblocked some things around media.

Flags: needinfo?(ohall)

It looks like bug 1698214 did clear many additional tests in the plain M suite, but some remain. M(mda1) & M(mda2) still have many failures.

M(2)

  • TEST-UNEXPECTED-FAIL | netwerk/test/mochitests/test_android_content_uri.html | [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIAndroidContentInputStream.init]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame :: resource://testing-common/WrapPrivileged.sys.mjs :: doApply :: line 117" data: no] - Should not throw any errors

M(mda1) & M(mda2)

  • PROCESS-CRASH | dom/media/autoplay/test/mochitest/mochitest.toml
  • PROCESS-CRASH | dom/media/mediasource/test/mochitest.toml
  • PROCESS-CRASH | dom/media/test/mochitest.toml
  • TEST-UNEXPECTED-FAIL | dom/media/test/test_complete_length.html | Test timed out.
  • TEST-UNEXPECTED-ERROR | dom/media/test/test_complete_length.html |
  • TEST-UNEXPECTED-FAIL | dom/media/test/test_complete_length.html
  • TEST-UNEXPECTED-FAIL | dom/media/test/test_streams_element_capture.html
  • PROCESS-CRASH | application crashed [None] | dom/media/test/mochitest_stream.toml
  • TEST-UNEXPECTED-ERROR | dom/media/test/test_streams_individual_pause.html | called finish() multiple times
  • And so on ...

Notably see in the logs:

04-28 20:06:58.482  3753  3769 E HardwareCodecCapability: Failed to retrieve media codec support list
04-28 20:06:58.482  3753  3769 E HardwareCodecCapability: java.lang.RuntimeException: cannot get MediaCodecList

Possibly connected to same root cause of remoting issues in bug 1961624. Maybe will be fixed by bug 1934009, would need to research further to confirm same causes.

Flags: needinfo?(ohall)

TEST-UNEXPECTED-FAIL | netwerk/test/mochitests/test_android_content_uri.html | [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIAndroidContentInputStream.init]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame :: resource://testing-common/WrapPrivileged.sys.mjs :: doApply :: line 117" data: no] - Should not throw any errors

This is bug 1952525. This should be converted to mochitest-browser, mochitest-chrome or xpcshell. But I guess that mochitest-browser and mochitest-chrome won't run on GeckoView. So I am considering it to convert to xpcshell if possible.

Keywords: meta
Summary: Fix mochitests for isolated process → [meta] Fix mochitests for isolated process
Depends on: 1952525
Blocks: 1934009
No longer blocks: 1934009
Depends on: 1934009
See Also: → 1975257

Mochitests will have metadata categorizations as soon as bug 1975257 lands.

The failing mochitests can be found by searching this bug number bug 1709948.

Depends on: 1698178
See Also: → 1988531
Depends on: 1994202
You need to log in before you can comment on or make changes to this bug.