1771653 - Contact picture in message header not properly aligned

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Andreas]

Attachment: Contact picture alignment.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4951.64 Safari/537.36 Edg/101.0.1210.53

Steps to reproduce:

Select the option to show the contact picture in the mail header. This option was introduced in bug 1556261. Don't select the option to show the sender's e-mail address below the display name.

Actual results:

The contact picture is not properly aligned to the text.

Expected results:

Move the contact picture some pixels towards the top.

Comment 1

[Alessandro Castellani [:aleca]]

Thanks for the report.
Could you please tell me the Density setting and Font Size of the app you're currently using?
Thanks.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Bug 1771653 - Better align the message header profile picture. r=Paenglab

Comment 3

[Andreas]

My settings are:
Density: Compact
Font Size: 12 px

Comment 4

[Alessandro Castellani [:aleca]]

This will need 102 uplift.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/173017440f3b
Better align the message header profile picture. r=Paenglab

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9278681 [details]
Bug 1771653 - Better align the message header profile picture. r=Paenglab

[Triage Comment]
Approved for 102.0b1.

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.0beta1:
https://hg.mozilla.org/releases/comm-beta/rev/354d26b09ccb

Comment 8

[Andreas]

Strange. If there is no contact picture in the address book, the placeholder is in the right position. But with a contact picture, it now moves to the top.

Comment 9

[Alessandro Castellani [:aleca]]

What's the placeholder?
Would you be able to share a screenshot with the issue?

Comment 10

[Richard Marti (:Paenglab)]

Attachment: with-image.png

I haven't tested with an image. :-(
Here a screenshot with image as avatar. I hovered to see the boundaries of the button better.

Comment 11

[Andreas]

Attachment: TB contact picture.png

See the attached screenshot of the same mail when there is no picture (left) and a picture (right) stored in the address book. Screenshots taken with "touch" density for better visibility, but the behavior is the same for other densities.
The placeholder is the circle with a single letter when there is no contact picture in the address book.

Comment 12

[Alessandro Castellani [:aleca]]

Ah! I see the problem!

Comment 13

[Alessandro Castellani [:aleca]]

Attachment: Bug 1771653 - Fix message header profile picture alignment. r=Paenglab

Comment 14

[Alessandro Castellani [:aleca]]

Attachment: header-alignment.png

The new patch should fix everything, tested with all scenarios.
Missing something?

Comment 15

[Alessandro Castellani [:aleca]]

Attachment: header-alignment.png

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/888918704753
Fix message header profile picture alignment. r=Paenglab

Comment 17

[Alessandro Castellani [:aleca]]

Comment on attachment 9278965 [details]
Bug 1771653 - Fix message header profile picture alignment. r=Paenglab

[Approval Request Comment]
Regression caused by (bug #): bug 1556261
User impact if declined: Wrong alignment of elements when customizing the message header UI
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 18

[Rob Lemley [:rjl]]

Resetting 102 status so the follow-up doesn't get missed in beta2.

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9278965 [details]
Bug 1771653 - Fix message header profile picture alignment. r=Paenglab

[Triage Comment]
Approved for beta

Comment 20

[Rob Lemley [:rjl]]

Thunderbird 102.0beta2:
https://hg.mozilla.org/releases/comm-beta/rev/e7da5962cb45