Open Bug 1556261 Opened 2 years ago Updated 2 months ago

Re-Implement message header button customisation (feature removed in 69+)

Categories

(Thunderbird :: Toolbars and Tabs, defect)

defect
Not set
normal

Tracking

(thunderbird_esr78 affected, thunderbird80 affected, thunderbird81 affected)

Tracking Status
thunderbird_esr78 --- affected
thunderbird80 --- affected
thunderbird81 --- affected

People

(Reporter: jorgk-bmo, Unassigned)

References

Details

(Keywords: regression)

+++ This bug was initially created as a clone of Bug #1553427 +++
+++ This bug was initially created as a clone of Bug #1535265 +++

In bug 1535265 the message header toolbar was removed in TB 68. In bug 1553427 it was restored for TB 68 during the 69 cycle, leaving TB 69 and later without customisation facility for the message header.

There has been some discussion about how to replace the customisability in bug 1553427 comment #23 and subsequent comments, so here is the bug to implement something.

One thing worth thinking about here: in addition to the message header toolbar, there's also the multimessage header toolbar (it's the thing you get when you select multiple messages, and shows "Archive" and "Delete"). If we make a new customization widget, it'd be nice if we could support customizing both the regular message header toolbar as well as the multimessage version. See also bug 519671 which requested this and has a very old patch and somewhat-hacky patch I wrote.

This would have the side benefit that we could move the "Tag" button from the main toolbar to the message/multimessage toolbar if we wanted to. Putting the "Tag" button in the main 3pane toolbar always seemed like a weird fit to me, since it's designed to operate on selected messages, and every other button like that is in the header toolbars. Since the multimessage header toolbar isn't currently customizable, I never pushed very hard to make this change; it would have just taken up extra space without a way to get rid of it.

Using the CompactHeader addon, you can add different buttons, normally only available in the main toolbar, to the header pane toolbar, e.g. the tag button.

But of course, this requires the header pane toolbar to be customizable at all. So at the moment, it does not work with the daily builds (Thunderbird 69)

Duplicate of this bug: 1569489

(In reply to Jim Porter (:squib) from comment #1)

This would have the side benefit that we could move the "Tag" button from the main toolbar to the message/multimessage toolbar if we wanted to. Putting the "Tag" button in the main 3pane toolbar always seemed like a weird fit to me, since it's designed to operate on selected messages, and every other button like that is in the header toolbars. Since the multimessage header toolbar isn't currently customizable, I never pushed very hard to make this change; it would have just taken up extra space without a way to get rid of it.

The same applies to the star toolbar button.

Version: Trunk → 69
Duplicate of this bug: 1598887
See Also: → 519671
Duplicate of this bug: 1613965

Let's call this a regression since it's still working in TB 68 (via backout). Magnus & Alex, we're at TB 76 now, is this bug on the radar?

Type: enhancement → defect
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(alessandro)
Keywords: regression

Hey, thanks for the heads up on this bug.
What's the objective on this? Do we all agree that having a customizable toolbar in the message header is the proper solution?

I personally don't have a strong opinion on this and I understand both point of views of having a customizable message header area, or having a more polished and optimized static area that doesn't require customization.

Flags: needinfo?(alessandro)

Well, see comment #0 and the bugs and comments referenced there.

I think we shouldn't make it customizable.
There is the https://thunderbird-webextensions.readthedocs.io/en/latest/browserAction.html add-ons can use to add buttons
We should make sure the More button works better, maybe like the toolbar overflow in Firefox (the >>>).

Compact header was brought up above: seems to me it doesn't really make a difference to it what we do wrt customizability. I guess it wanted customizability since that worked well with overlays, but overlays are now also gone. Going forwards it would have to touch the DOM manually, e.g. just remove the nodes that are there and add it's own and then customizability something to worry about.

Flags: needinfo?(mkmelin+mozilla)

I'd like to take this to do some mock-ups to refresh the UI and properly reorganize the buttons.
If you guys agree I can kick off the conversation on the UX topicbox so this change won't come as a surprise and we can collect feedback to satisfy the needs of everyone (high hopes).

(In reply to Alessandro Castellani (:aleca) from comment #11)

I'd like to take this to do some mock-ups to refresh the UI and properly reorganize the buttons.
If you guys agree I can kick off the conversation on the UX topicbox so this change won't come as a surprise and we can collect feedback to satisfy the needs of everyone (high hopes).

I agree.

I would like to be able to see icons only, remove Archive, Forward, Reply (when Smart Reply is already in the email header), Reply (when Followup is already in the newsgroup post header) and probably Junk from some accounts.

Users have been able to do that since I can remember and still can using version 68.8.0.

Duplicate of this bug: 1647201
Duplicate of this bug: 1650595
Duplicate of this bug: 1656031

It's also important to be able to 'restore default set' - I have often had to advise people to use this in the support forum - or choose whether you want text and icon or either. Personally, I want to see both text and icon, but others may want to customise otherwise.

Whilst 'Tag' is a per message and I have seen support forum requests asking to be able to set a 'Tag' whilst composing an email, I usually tag something that is in the 'Thread Pane', so Tag in it's current location works well for me. But, I can see 'tag' would be useful option in the Message Header area and also when composing a new/reply email. So adding 'tag' to the 'Customise' would be a good option.

I agree with the common sentiment on this bug that we should continue to offer message header customization, because different users have different needs.

  • On small screens or using TB side by side with another app, having "Icons only" (vs. Icons and Text) is important.
  • Removing buttons which I'll never use is important.
  • Adding buttons which are important for my workflows is important.

(In reply to Anje from comment #16)

It's also important to be able to 'restore default set' - I have often had to advise people to use this in the support forum - or choose whether you want text and icon or either. Personally, I want to see both text and icon, but others may want to customise otherwise.

+1

Whilst 'Tag' is a per message and I have seen support forum requests asking to be able to set a 'Tag' whilst composing an email, I usually tag something that is in the 'Thread Pane', so Tag in it's current location works well for me. But, I can see 'tag' would be useful option in the Message Header area and also when composing a new/reply email.

Please check if there's a bug for tagging when composing (assuming that's technically feasible), otherwise pls file it.

So adding 'tag' to the 'Customise' would be a good option.

For message reader of TB 68, Tag button is available from toolbar customization of msg header toolbar (implemented by bug 456169).

User in Support Forum is requesting a need to Customise the buttons in the Message header.
https://support.mozilla.org/en-US/questions/1297459

Indeed there have been quite a few requests. We'll see more once auto update is enabled. Is this in some ways a duplicate of bug 766295?

However, in some cases (and they may not articulate this) it's more about wanting shorter headers ala bug 634831 (I'm in that camp).

There are also bug 466025 and bug 543954

See Also: → 634831
Duplicate of this bug: 1658559

Please note that bug 1658559 is not about reinstating and redesigning the Customise Message Header which is missing in 78.

It is about reimplementing the option to 'Add new toolbar' to the Mail Toolbar Customise in 78. This option is suddenly missing , perhaps forgotten to get added and needs putting back.

Not sure if this is also effecting the TagToolbar addon, as that used to have option to add new toolbar and this no longer works or cannot be added either and addon has been updated to work with 78.

Being able to 'Customise' is the biggest bonus that thunderbird offers because it is all about what the user wants. Kudos.

For TB 68 we simply backed out bug 1535265 in bug 1553427 to gain one year time. Sadly that time wasn't used to implement a new solution. IMHO the toolbar should just be restored until an acceptable replacement arrives.

(In reply to Jorg K (CEST = GMT+2) from comment #22)

For TB 68 we simply backed out bug 1535265 in bug 1553427 to gain one year time. Sadly that time wasn't used to implement a new solution. IMHO the toolbar should just be restored until an acceptable replacement arrives.

That sounds like common sense.
Implement the old until the new is ready.

I cannot fathom why it was removed in the first place. There have been many many occasions when I have had to help on support forum to reset to default because something had gone wrong.

Can the old be pushed forward to be on next update until a suitable new model is finalised ?

While one could get to an agreement that customizability of the header pane (without Add-ons) is probably just another piece of clutter, we definitely need the "Icon only" mode. Because the header area is very small in 3pane view and some of the real-estate is needed for additional tools (such as DispMua).

So my proposal is at least make the text removable (icons only mode), and, to be even more minimalist, I would not display the labels as a default setting - the tooltips are sufficient for Newbies - just look at many webpages and apps that use icons, with well-designed Icons they often do not have labels either. There are many users who have additional functionality in the main toolbar (a wider area) and do not understand that they are MISSING FUNCTIONS because the buttons are hidden in overflow because the labels take up so much screen space and buttons start to go missing to the right.

imho it makes little sense to have even more labels in the header area - the header area should be mainly about the headers! And imho that area of the screen (right half - center of the screen) should not distract from the messages list/message preview - that's where the reading should happen.

I detest only icon. Text is a must. There is nothing more of a pain than being presented with a bunch of icons and needing to constantly hover to locate tooltips. But if you like that then it should be an option for you.

There is nothing more difficult than trying to explain to someone via a Support Forum or over a phone what a particular icon looks like, but if you say click on button that says 'Reply' then they know what to do. We are talking of coping with an extensively wide range of skillset and abilities and needs. Thunderbird needs to incorporate it into it's very fabric. So saying newbies can use a tooltip is not understanding someone elses situation at all.

Nothing is cluttered on my view - far from it I have plenty of space, so everyone obviously has different needs.
The logical conclusion is to offer options to cope with differents needs.
Adding back the ability to add a new toolbar onto the 'Menu Bar' for anyone requiring additional space for any reason should be considered especially as it would solve more issues than being considered here. Then those who do not want the Message Header being further cluttered can use it. It is a perfect solution for those who actually use the Message Pane and do not open in a new tab or window. This also should not have been removed in the first place.

This customise option in the Message Header should never have been removed, it's not just about a few icons with or without text. I cannot think if one reason to make it impossible to reset to default when it all goes wrong and it does.

Thunderbird is the tool that offers flexibility for everyone, we should be proud of that and enhance it, but there are some who appear to dismiss this hence why there is no customise option currently in 78 - no ability to reset to default if there's a problem ; no ability to add a toolbar to cope with those people who have a load of additional icons and options like tags which they want separate with easy access to enable.

Please just apply some common sense and just add the old version back and it will solve a bunch of problems in one fell swoop.
Then work out what additional elements need to be applied in an upgrade.

Duplicate of this bug: 1660812
Summary: Implement message header button customisation → Re-Implement message header button customisation (feature remove in 69
Summary: Re-Implement message header button customisation (feature remove in 69 → Re-Implement message header button customisation (feature removed in 69+)

Please make it clear in the release notes for versions 78.* that this feature has been removed. It is not simply a regression in the sense of an error that will be fixed for the user in the short term.

re : It is not simply a regression in the sense of an error

It would seem to have been removed by accident or oversight or probably because the person who made the decision to remove it, does not actually use it and therefore does not or cannot comprehend why others require it. In the same way that it is no longer possible to create additional toolbars Or why virtually all Options/Preferences are now lumped into one General scrollable heap. Someone is making what allegedly appears to be some very unreasonable decisions despite there being an obvious support to this bug.

(In reply to Richard Marti (:Paenglab) from comment #29)

There exists an add-on to customize the buttons: https://addons.thunderbird.net/thunderbird/addon/msghdr-toolbar-customize.

Thanks for pointing that out, but sorry that is blanket add-on that applies to all types of accounts.

I had/like different buttons for different types of accounts and removing customization broke that capability.

Duplicate of this bug: 1665388
Duplicate of this bug: 1665811
Blocks: 1669063

Just to add another reason why this is an important feature: When forwarding an address from GMail, Google sneaks in list headers. On the one hand, this allows any third party mail server to send from the original address through Google, on the other hand when it is not needed, it leaks sent messages to Google.

As such, it would be very useful to replace the smart-reply button with reply-all to avoid accidentally compromising privacy.

(In reply to WaltS48 [:walts48] from comment #30)

(In reply to Richard Marti (:Paenglab) from comment #29)

There exists an add-on to customize the buttons: https://addons.thunderbird.net/thunderbird/addon/msghdr-toolbar-customize.

> Thanks for pointing that out, but sorry that is blanket add-on that applies to all types of accounts.

> I had/like different buttons for different types of accounts and removing customization broke that capability.

After using this extension and becoming more familiar with it, I can do everything I did before, but having the original feature back would be nice.

Why are we removing basic functionality that has been available for eons, to replace with an Add-on ?

It is not an improvement to deliberately and willfully create situations, by removal of code, where addons become vital for basics or required because they fix a bug as in this instance.

Removal of customise showed a complete ignorance and lack of deference for language and the impact of spelling variants; not all languages have words that are short. eg: German where the button labels are much longer than in English.

bug 1670934 -Reduce width of Message Pane to the point where the Message Pane buttons 'Reply, Forward, Archive,Junk, Delete, More' start to occupy full width, then as you further reduce the width, the vertical scrollbar will disappear completely and Buttons and Header and text/Body content of message becomes truncated. Cannot get access to full content.
So the addon is now required to get around this bug which previously could be remedied via Customise.

I'm one of those 'helpers' who sees the impact of this in the Support Forum and it gives me no pleasure in taking the backlash from users who now find basic usability preferences being removed for no good reason. Especially when they can be implemented so easilly.

When is 'Customise' going to be implemented properly again ?........because in the Support Forum users are asking.
Removal of customise was blatantly a poor decision. But who has the gumption to acknowedge it and fix it.

At least the flag thunderbird_esr78 = affected is set. But I think it's unrealistic that it will be fixed for 78 ESR. So we will wait 1 year for Thunderbird 90 and put people off for a long time.

It is good that Thunderbird is being developed significantly again. And in the long run it is certainly a good thing that the internal code is modernized. You know, I've been with @mscott since before version 0.1 as a german translator. But Thunderbird 78 has unfortunately become the biggest disaster. And I don't mean the development towards MailExtensions.

Version 78 is also now with version 78.4.0 at best a beta version with still so many unforeseen problems with light / dark theme, certificates, OpenPGP and support of CalDAV / CardDAV.

It is sad to see this. I strongly recommend a more stable release for Thunderbird 90. We currently have too many construction sites on the program at the same time. This can not go well.

Duplicate of this bug: 1674678
See Also: → 1675867

I'm getting a load of not very happy people in the Support Forum now that 78 has been made available as an auto update.
Removing a customise option that has been around for eons is not being well received.

Duplicate of this bug: 1676341

There should also be an option to move the toolbar to the left or right, as the old CompactHeader extension allowed for. Usually there is more space on the screen in horizontal direction than in vertical direction, at least in classic and wide layout.

Duplicate of this bug: 1685815
Duplicate of this bug: 1694592

Still not planned ?

(In reply to Florent from comment #43)

Still not planned ?

See comment 29 and comment 34.

(In reply to WaltS48 [:walts48] from comment #44)

(In reply to Florent from comment #43)

Still not planned ?

See comment 29 and comment 34.

But the downside of relying on plug-ins such as Message Header Toolbar Customerize is highlighted by user Bob's review comment of Feb 22, 2021, where he notes that it stopped working with the release of Thunderbird 78.7.1. Synchronization cannot be guaranteed. Basic fucntionality, especially that which already existed prior to v78 really should stay with the core product. Please restore.

For me extension not work correctly. Button "Reply for all" or "reply to the list" not show.
I know it's not mozilla problem but regret removal of this simple personnalization :(

(In reply to Florent from comment #46)

For me extension not work correctly. Button "Reply for all" or "reply to the list" not show.
I know it's not mozilla problem but regret removal of this simple personnalization :(

Did you file a bug report or look for one on the extensions Issue Tracker?

Are the messages where you don't see the buttons list or multiple recipient emails?
The buttons in the message headers change for me depending on the message.
List and multiple recipient messages show those buttons. Single recipient messages don't show them.
Next to the Delete button is a down arrow with "Customize Toolbar" at the bottom when you view the menu items.
Open it to get the extensions options. You may just need to show or hide the buttons.

You need to log in before you can comment on or make changes to this bug.