1772583 - Delete context menu item has no label

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: no-delete.png

Apparently the patch for bug 1426817 caused some part of the XUL commands logic or similar to panic. As a result, with this patch applied the context menu will not show any label for the delete menu item.

Comment 1

[Alessandro Castellani [:aleca]]

Apparently this is the problematic code: https://searchfox.org/comm-central/rev/54fa177684376fecd6f73382036d60556a7c9ba5/mail/base/content/messenger.xhtml#260-266

It seems that XUL doesn't accept multiple root commandset but only a single commandset with various child elements.
Moving that new commandset as children of mailCommands seems to solve the issue.

Comment 2

[John Bieling (:TbSync)]

Wow, that was fast. Thanks for digging into that! I will create a patch to fix this.

Comment 3

[John Bieling (:TbSync)]

Attachment: Bug 1772583 - Fix missing delete context menu item label. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a07c852b317d
Fix missing delete context menu item label. r=aleca DONTBUILD

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9279689 [details]
Bug 1772583 - Fix missing delete context menu item label. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.0beta7:
https://hg.mozilla.org/releases/comm-beta/rev/065313bcb172