1773406 - File menu item hidden or covered by spaces toolbar in 102 beta

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David McDivitt]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.63 Safari/537.36

Steps to reproduce:

Upgraded to 102 beta with overwrite.
Opened and closed Thunderbird a couple of times.

Actual results:

The new vertical nav bar or spaces nav bar with icons for mail, address book, etc., overlaps the file menu item making the file menu item inaccessible.

Expected results:

Either the menu bar should be moved right or vertical spaces nav bar should be moved down so not to cover the file menu item.

Comment 1

[Magnus Melin [:mkmelin]]

Screenshot?

Comment 2

[David McDivitt]

Attachment: 2022-06-09 07_58_45-Inbox - [e-mail] - Mozilla Thunderbird.png

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

I think this is because your "tabs" bar is hidden. Or the tabs are above your menubar but are cut off in the screen shot (this happens on windows 7, I think, from https://searchfox.org/comm-central/source/mail/themes/windows/mail/primaryToolbar.css#224-229).

Have you got an addon, a theme, or use userChrome.css that is hiding the tabs?

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

For microsoft windows 7, see bug 1773490

Comment 5

[Richard Marti (:Paenglab)]

It's possible to hide the tab bar with setting mail.tabs.autoHide to true. When only one tab is open, the tab bar is collapsed.

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Richard Marti (:Paenglab) from comment #5)

It's possible to hide the tab bar with setting mail.tabs.autoHide to true. When only one tab is open, the tab bar is collapsed.

Is that a hidden preference?

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Henry Wilkes (they/them) [:henry] from comment #6)

Is that a hidden preference?

Yes, only available through about:config (Settings/General on bottom the "Config Editor" button).

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug 1773406 - Don't apply a negative margin on spaces-toolbar when tab bar is hidden. r=aleca

Comment 9

[David McDivitt]

(In reply to Henry Wilkes (they/them) [:henry] from comment #3)

I think this is because your "tabs" bar is hidden. Or the tabs are above your menubar but are cut off in the screen shot (this happens on windows 7, I think, from https://searchfox.org/comm-central/source/mail/themes/windows/mail/primaryToolbar.css#224-229).

Have you got an addon, a theme, or use userChrome.css that is hiding the tabs?

No. I do not have an add-on hiding the tabs. I it appears the new spaces toolbar was designed to lay alongside tabs. If for instance I open a new tab, everything fits nicely. I do not use tabs and hate tabs. I view messages in their own window. If I have only one page open such as the default Thunderbird message list with a folder pane, there is no tab bar. If I open a second page, everything moves down, the tab bar appears, the message list occupies the first tab, and whatever content occupies the second tab. If I close the second tab the tab bar goes away and everything moves back up. Because the spaces bar was made expecting tabs, when the tab bar goes away it moves up and shares the same real estate as the menu bar, ending up on top of the menu bar and hiding the menu item "file".

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/43e6ede7443c
Don't apply a negative margin on spaces-toolbar when tab bar is hidden. r=aleca

Comment 11

[Richard Marti (:Paenglab)]

Comment on attachment 9283798 [details]
Bug 1773406 - Don't apply a negative margin on spaces-toolbar when tab bar is hidden. r=aleca

[Approval Request Comment]
Regression caused by (bug #): spaces toolbar bug
User impact if declined: main button on spaces toolbar not accessible when tabs are hidden
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9283798 [details]
Bug 1773406 - Don't apply a negative margin on spaces-toolbar when tab bar is hidden. r=aleca

[Triage Comment]
Approved for beta

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 103.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/123b4e114b30

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9283798 [details]
Bug 1773406 - Don't apply a negative margin on spaces-toolbar when tab bar is hidden. r=aleca

[Triage Comment]
Approved for esr102

Comment 15

[Rob Lemley [:rjl]]

https://hg.mozilla.org/releases/comm-esr102/rev/6445b1b3f4f4