1774040 - Message pane varies in size in new profiles

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[[e-mail]]

Bug 1752038 introduced the following code:

  for (let attrName of ["collapsed", "height", "width"]) {
    messagepaneboxwrapper.setAttribute(
      attrName,
      Services.xulStore.getValue(
        "chrome://messenger/content/messenger.xhtml",
        "messagepaneboxwrapper",
        attrName
      )
    );
  }

Unfortunately this means that in profiles where the user has never adjusted their message pane size, the default dimensions in the XUL html are deleted. This causes the message pane to vary in size according to its content (start page, single message, conversation).

Comment 1

[Wayne Mery (:wsmwk)]

see Bug 1773257 - Message Pane and Emails list (column) horizonal resizing when changing messages

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1774040 - Check for attribute values before assigning them to #messagepaneboxwrapper. r=#thunderbird-reviewers

Comment 3

[Geoff Lankow (:darktrojan)]

Is that better, Neil?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/74dfcf858614
Check for attribute values before assigning them to #messagepaneboxwrapper. r=#thunderbird-reviewers,mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9281330 [details]
Bug 1774040 - Check for attribute values before assigning them to #messagepaneboxwrapper. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: message pane weirdness due to missing size values
Testing completed (on c-c, etc.): landed yesterday
Risk to taking this patch (and alternatives if risky):

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9281330 [details]
Bug 1774040 - Check for attribute values before assigning them to #messagepaneboxwrapper. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.0beta7:
https://hg.mozilla.org/releases/comm-beta/rev/a14ae73915cf

Comment 8

[[e-mail]]

Comment on attachment 9281330 [details]
Bug 1774040 - Check for attribute values before assigning them to #messagepaneboxwrapper. r=#thunderbird-reviewers

Sure, seems reasonable.