1774432 - Implement a reliable mock of BuiltInThemes and BuiltInThemeConfig for tests

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[kpatenio]

BuiltInThemes and BuiltInThemeConfig are utilized heavily for Colorway Closet. However, we do not have any "official" implementation of it to be used globally for tests.

Currently, there is an "unofficial" implementation in toolkit/mozapps/extensions/test/browser/browser_colorwaycloset_aboutaddons.js that can be used as a reference.

We may also wish to mock BuiltInTheme instead of BuiltInThemeConfig (or vice versa) to avoid the need for importing two jsm files. For instance, BuiltInTheme.findActiveColorwayCollection calls BuiltInThemeConfig.findActiveColorwayCollection (searchfox)

Comment 1

[kpatenio]

browser/browser_colorwayCloset.js uses sinon to stub out certain methods in BuiltInThemes. We should create a head.js file that will contain the general sinon infrastructure previously made and update browser/browser_colorwaycloset_aboutaddons.js to use these doubles.

Comment 2

[kpatenio]

Attachment: Bug 1774432 - consolidate BuiltInTheme mocks for browser_colorwayCloset.js and browser_colorwaycloset_aboutaddons.js

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/493bd0be18e2
consolidate BuiltInTheme mocks for browser_colorwayCloset.js and browser_colorwaycloset_aboutaddons.js r=bigiri,dao,rpl

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/493bd0be18e2