1774183 - Improve test coverage for colorwaycloset.js

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Bernard Igiri]

https://searchfox.org/mozilla-central/source/browser/components/colorways/colorwaycloset.js needs better test coverage. See the following test coverage report: https://coverage.moz.tools/#revision=latest&path=browser%2Fcomponents%2Fcolorways%2Fcolorwaycloset.js&view=file

We need tests to cover the conditional statements.

Comment 1

[Bernard Igiri]

Attachment: Bug 1774183 - Improve test coverage of colorwaycloset.js r=Gijs!

Added tests to improve test coverage of colorwaycloset.js

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0783edbc00a5
Improve test coverage of colorwaycloset.js r=Gijs

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_colorwayCloset.js

• backout: https://hg.mozilla.org/integration/autoland/rev/8470e313101ed1b888b55f18920033bc52e31a7a
• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=0783edbc00a5d0b294964347140f1b1f18f89c99&group_state=expanded
• push where tier 1 showed up: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=KdlVFp_rRYiw-LJBwIBu0w.0&revision=b8740c0dade37fbaa6f39b89727dbf9fdc69b72a&searchStr=browser-chrome
• failure log: https://treeherder.mozilla.org/logviewer?job_id=383025338&repo=autoland&lineNumber=7705

[task 2022-06-30T14:00:45.124Z] 14:00:45     INFO - TEST-PASS | browser/components/colorways/tests/browser/browser_colorwayCloset.js | Correct expiry date format should be shown - 
[task 2022-06-30T14:00:45.124Z] 14:00:45     INFO - Buffered messages finished
[task 2022-06-30T14:00:45.125Z] 14:00:45     INFO - TEST-UNEXPECTED-FAIL | browser/components/colorways/tests/browser/browser_colorwayCloset.js | A promise chain failed to handle a rejection: can't access property "figureUrl", BuiltInThemes.builtInThemeMap.get(...) is undefined - stack: _getFigureUrl@chrome://browser/content/colorwaycloset.js:145:42
[task 2022-06-30T14:00:45.126Z] 14:00:45     INFO - _displayColorwayData@chrome://browser/content/colorwaycloset.js:154:39
[task 2022-06-30T14:00:45.126Z] 14:00:45     INFO - refresh@chrome://browser/content/colorwaycloset.js:224:14
[task 2022-06-30T14:00:45.127Z] 14:00:45     INFO - _initColorwayRadios@chrome://browser/content/colorwaycloset.js:97:12
[task 2022-06-30T14:00:45.128Z] 14:00:45     INFO - Rejection date: Thu Jun 30 2022 14:00:44 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 271
[task 2022-06-30T14:00:45.128Z] 14:00:45     INFO - Stack trace:
[task 2022-06-30T14:00:45.129Z] 14:00:45     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:271
[task 2022-06-30T14:00:45.129Z] 14:00:45     INFO - chrome://mochikit/content/browser-test.js:handleTask:1017
[task 2022-06-30T14:00:45.130Z] 14:00:45     INFO - resource://gre/modules/SubDialog.jsm:close/<:283
[task 2022-06-30T14:00:45.137Z] 14:00:45     INFO - Leaving test bound colorwaycloset_show_colorway
[task 2022-06-30T14:00:45.139Z] 14:00:45     INFO - Entering test bound colorwaycloset_custom_home_page
[task 2022-06-30T14:00:45.140Z] 14:00:45     INFO - Set custom home page

Comment 4

[Bernard Igiri]

I'll take a look.

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/2623fbce90ae