Closed Bug 1775093 Opened 4 years ago Closed 4 years ago

Add-on incompatibility notification not displayed due to missing string details-notification-incompatible-link from aboutAddons.ftl

Categories

(Thunderbird :: Add-Ons: General, defect, P3)

Thunderbird 102
defect

Tracking

(thunderbird102? fixed)

RESOLVED FIXED
103 Branch
Tracking Status
thunderbird102 ? fixed

People

(Reporter: john, Assigned: john)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

+++ This bug was initially created as a clone of Bug #1773568 +++

Until Bug 1773568 has been uplifted, we need to find a temporary workaround for ESR 102.

Why don't you just request uplift in bug 1773568? Take a look at bug 1772906 to see how uncomplicated that can be, especially for a one liner.

They won't. It's a new string and 102 is beyond string freeze. See comment in the patch in bug 1773568.

Target Milestone: --- → 103 Branch
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/b9f342c2074a follow-up - Fix linting errors. rs=linting

Comment on attachment 9282048 [details]
Bug 1775093 - Temporary fix for Bug 1773568. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
1507471

User impact if declined:
No information displayed to the user, that an add-on has been disabled because it is incompatible.
Testing completed (on c-c, etc.):
Manually tested.

Risk to taking this patch (and alternatives if risky):
Medium. It monkey patches a function with a 99% copy of the original, which is regressed. There could be a timing issue, which makes the add-on-card not use the monkey-patched version, but keeps using the original one.

Attachment #9282048 - Flags: approval-comm-beta?

Comment on attachment 9282048 [details]
Bug 1775093 - Temporary fix for Bug 1773568. r=mkmelin

[Triage Comment]
Approved for beta

Attachment #9282048 - Flags: approval-comm-beta? → approval-comm-beta+
See Also: → 1779248
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: