1775296 - Message header "starred" checkbox has wrong aria-label when unchecked

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Steps to reproduce

1. Turn screen reader on.
2. Open Thunderbird.
3. Select a non-starred message.
4. Navigate to the starred "button".

Result

Screen reader reads something like "Not starred Checkbox. Not Ticked". This implies it is a checkbox for the "Not starred" state, rather than the "Starred" state. So we have a double-negative which is either confusing or interpreted the wrong way around.

Expect

Screen reader reads "Starred Checkbox. Not Ticked".

Origin

The aria-label should not change when the "button" toggles between checked and not checked. Basically this line https://searchfox.org/comm-central/rev/96e876dbe3b2875e26f357152758d16c6908af4c/mail/locales/en-US/messenger/messenger.ftl#149 should be "Starred" as well, or both be "Starred Message".

I personally think the the title should describe the action rather than the state so it also acts as a useful accessible description, but that might be out of scope.

See the second to last paragraph of bug 1556261 comment 75.

Comment 1

[Alessandro Castellani [:aleca]]

Based on bug 1775273, that aria-label addition was also wrong since we didn't update the fluent ID, so translators won't pick up that change.

Comment 2

[Alessandro Castellani [:aleca]]

Mistake introduced here: https://hg.mozilla.org/comm-central/rev/9e43bc3f94ec0b4660a0146bbbb0c4003e229d60#l6.18

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Bug 1775296 - Fix wrong fluent ID for the starred checkbox in message header. r=henry

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6b5cd09e5a61
Fix wrong fluent ID for the starred checkbox in message header. r=henry

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9282414 [details]
Bug 1775296 - Fix wrong fluent ID for the starred checkbox in message header. r=henry

[Approval Request Comment]
Regression caused by (bug #): bug 1556261
User impact if declined: Wrong untranslated fluent strings for the starred icon in the message header
Testing completed (on c-c, etc.): soon on c-c (currently building)
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9282414 [details]
Bug 1775296 - Fix wrong fluent ID for the starred checkbox in message header. r=henry

[Triage Comment]
Approved for esr102

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.0:
https://hg.mozilla.org/releases/comm-esr102/rev/68cfa46e3641