1776069 - WDBA should record when "Don't Show Again" was pressed

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, task, P3)

Description

[Robin Steuber (she/her) [:bytesized]]

Part of the design of the WDBA was that notifications would only ever be shown once, or twice if "Remind me later" was pressed. Thus, we didn't have to store anywhere that the user pressed "Don't show again" because it would never be shown again regardless.

However, we are now looking into having that notification be shown more times. Ideally, we would respect the user's choice if they selected "Don't show again" in the past. But since we didn't need to store that information, we don't know which users pressed that. So we should start recording that ASAP so that future attempts to show the dialog respect it.

Comment 1

[Robin Steuber (she/her) [:bytesized]]

As part of this bug, I am also going to be adding a telemetry field called something like NotificationNotShownReason to record why the notification was not shown.

Comment 2

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1776069 - Have WDBA record when "Don't Show Again" was pressed r=nalexander

This also prevents the notification from being shown when the "Don't Show Again" button was pressed, but this shouldn't actually have any effect unless someone manually manipulates registry entries because we don't currently show notifications after this anyways. This functionality is being added in preparation for further changes that would allow the notification to be shown more times.

Comment 3

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1776069 - Add WDBA "notification_not_shown_reason" telemetry field r=nalexander

Add telemetry that records why we didn't show a notification. This is being added now in large part so that we can confirm when people aren't being showed the notification because they pressed "Don't Show Again" on a previous notification.

Depends on D151661

Comment 4

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1776069 data review.md

Comment 5

[Chris H-C :chutten]

Comment on attachment 9285196 [details]
Bug 1776069 data review.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Kirk Steuber is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a22f5ae169a4
Have WDBA record when "Don't Show Again" was pressed r=nalexander
https://hg.mozilla.org/integration/autoland/rev/dae2537b6ebc
Add WDBA "notification_not_shown_reason" telemetry field r=nalexander

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a22f5ae169a4
https://hg.mozilla.org/mozilla-central/rev/dae2537b6ebc