[PBM] Add variable allowPrivatePin to support pin private browsing experiment
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
People
(Reporter: pdahiya, Assigned: pdahiya)
References
(Blocks 1 open bug)
Details
Pinning Private Browsing Window feature is behind pref with no immediate plan to turn on by default in Fx104.
To support pinning experiment on about:privatebrowsing, we should expose a variable allowPrivatePin that takes a boolean value with fallbackPref as 'browser.privacySegmentation.windowSeparation.enabled' (Similar to aboutWelcome skipFocus pref https://searchfox.org/mozilla-central/rev/2946e9b450cb35afaf8dad927a8d187975dcd74d/toolkit/components/nimbus/FeatureManifest.yaml#178 ).
https://mana.mozilla.org/wiki/display/FPS/Pin+Private+Windows+to+taskbar+on+PBM+-+Fx104
Setting this variable as true from remote experiment JSON will update pref for users enrolled in branches where we want pin private browsing available
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
•
|
||
Current plan is to keep the experiment running till Fx106 so that user continue to have pref enabled till the feature is rolled out in Firefox by default with MR
@venetia @bhearsum checked the implementation and user will have pref flipped back to default after the experiment ends, so we should rely on above plan to keep experiment running till the private pinning is turned on by default. Will look some more if there is another option to handle it gracefully.
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
As confirmed in comment in bug link below, in an experiment allowPrivatePin doesn't need to be true at an earlier point (say on browser startup) in Firefox lifecycle for Private Pinning to work.
"pinToTaskbar(true) will work even if the pref is false (we just don't want to expose without that pref being set to true for now)."
Current plan is updated to click of PinToTaskbar button will invoke synchronously
a) set pref 'browser.privacySegmentation.windowSeparation.enabled' to true
b) Call PinToTaskbar(true) method of ShellService API.
https://bugzilla.mozilla.org/show_bug.cgi?id=1778182#c6
Closing enhancment bug as not needed/invalid. Thanks
Description
•