1777284 - After installing a language pack via Tools > Addons, application restart isn't requested, and it won't show in the language list of an already open Settings tab.

Status: NEW

(Toolkit :: Add-ons Manager, defect, P4)

Description

[Wayne Mery (:wsmwk)]

102.0 en-US on Windows.

Steps:

1. tools > add-ons and search on Italian
2. install Italian language pack
3. Settings > Languages > switched the language from English to Italian

Results: some of Settings tab changed to Italian iirc. I was not offered to restart Thunderbird. I manually restarted TB. Still no italian, and the Settings tab is now entirely blank. Restarted again. I now have information in the Settings tab.

I noticed in Error Console
[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessenger.canUndo]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://messenger/content/mailWindowOverlay.js :: SetupUndoRedoCommand :: line 3265" data: no] mailWindowOverlay.js:3265:33

Someone also posted this issue on Facebook

Comment 1

[Wayne Mery (:wsmwk)]

I installed language pack a second time (I don't know whether that was required).

This time in Settings, after changing English to Italiano, I am offered to Apply and Restart. That wasn't offered to me the first time. After restart I have my UI in Italian.

Comment 2

[Wayne Mery (:wsmwk)]

Further information.

(In reply to Wayne Mery (:wsmwk) from comment #0)

102.0 en-US on Windows.

Steps:

1. tools > add-ons and search on Italian
2. install Italian language pack
3. Settings > Languages > switched the language from English to Italian

Results: some of Settings tab changed to Italian [but none of the other UI]

A user also reports this for version 91 in bug 1774772

I manually restarted TB. Still no italian, and the Settings tab is now entirely blank. '

(After removing all languagues and restarting) I installed Italian pack, went to settings - Italian was not offered in languages. Restart, Settings tab is again '''blank'''.

But, after waiting 20-30 seconds the settings UI appeared. And Italian is listed. This delay is reminiscent of version 91 lanaguage pack issues which, at its worst, was bug 1728744. So maybe this is not a regression?

And there is also Bug 1746823 - Some menus have wrong display language (Finnish)

Comment 3

[Andrei Hajdukewycz [:sancus]]

@thomas8:

Can you reproduce this? I cannot, I've tried several ways and language pack installation seems to be working as expected, both via file and via preferences menu(direct download from ATN).

Comment 4

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Settings in Italian

Works for me perfectly on 102.0 (64 bit), Win10, exactly as it should.

Comment 5

[Thomas D. (:thomas8)]

After retesting this, I think I see now what Wayne has seen: It's a workflow problem - I guess none of us has followed his steps religiously so far (please do!), and the steps were a bit fuzzy. I've rewritten them with more detail to avoid any ambiguity.

STR

0. Open Settings tab (important!); ensure that you do not have Italian language pack installed.
1. Tools > Add-ons and Themes (important!)
2. In the "Find more add-ons:" search box, enter "Italian", press Enter
3. Click Add to Thunderbird for Italiano (it) Language Pack (second search result in the "Italian :: Search :: Add-ons for Thunderbird" results tab)
4. In the addons.thunderbird.net popup (upper right corner), click Add
5. Confirm next Popup with OK (when it says "Italiano (it) Language Pack was added") - just that (important!). Observe UI language as John Doe.
6. As an advanced user, switch to your previously open (!) Settings tab, search for language, and check if the just-installed language (Italian) is available in the language dropdown.

Actual result:

• After installing language pack as an add-on from ATN using Add to Thunderbird, Thunderbird does not prompt the user to restart, but a restart is required and expected for the add-on to take effect. From here, the user will have no clue what to do next to activate the new language pack.
• The just installed new language (Italian) is not available in the language dropdown of a previously open Settings tab (but closing and re-opening the settings tab fixes this).

Expected result:

• Regardless of installation method, user should always be prompted to restart Thunderbird after installing a language pack (as long as those restarts are still required).
• For bonus points, the just installed new language (Italian) should also be instantly available in the language dropdown of a previously open Settings tab without reopening the same.

Comment 6

[Thomas D. (:thomas8)]

Wayne, can you take it from here? Not sure if we can fix this in Thunderbird, probably a platform thing.

Comment 7

[Wayne Mery (:wsmwk)]

bug 1724360 or bug 1777658 ?