1777323 - View Source > Save Page As broken again

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P1)

Description

[Lasana Murray]

STR:
View source of an email, attempt to save it to disk.

Expected Results:
The file is saved.

Actual Results:
The file is not saved.

Comment 1

[Wayne Mery (:wsmwk)]

if Bug 1766030 flags are correct, this affects esr102

Comment 2

[:Gijs (out for now; he/him)]

Dupe of bug 1776108?

Comment 3

[Lasana Murray]

Attachment: Bug 1777323 - Add missing parameter to internalSave() call. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a7b1641bf1a9
Add missing parameter to internalSave() call. r=#thunderbird-reviewers,rnons

Comment 7

[Lasana Murray]

Comment on attachment 9283648 [details]
Bug 1777323 - Add missing parameter to internalSave() call. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1766030
User impact if declined: Users will not be able to View Source > Save As
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky): low, just adds the missing parameter

Comment 8

[Rachel Martin]

Please, now and in the future, request beta approval first or together with ESR approval. Please inform yourself how the release process works and which rules apply to uplifts.

Comment 9

[Rachel Martin]

"View Source > Save Page As" is NOT broken in TB 102, applying the patch breaks it. Note that bug 1766030 hasn't requested ESR 102 backport yet(?), so there is nothing to backport for Thunderbird other than for 103 beta.

Comment 10

[Lasana Murray]

(In reply to Rachel Martin from comment #9)

"View Source > Save Page As" is NOT broken in TB 102, applying the patch breaks it. Note that bug 1766030 hasn't requested ESR 102 backport yet(?), so there is nothing to backport for Thunderbird other than for 103 beta.

Good catch. Thanks. Wayne 102 does not seem affected to me. At least by the m-c changes.

Comment 11

[Wayne Mery (:wsmwk)]

I flagged it based on bug 1766030, and bug 1766030 says firefox esr102 is affected

Comment 12

[Rachel Martin]

Greetings, as you know, we're running a fork of Thunderbird and therefore we're following your release activities. Our project benefits greatly from the good work you're doing and therefore we're more than happy to give back to Thunderbird.

Let's look at the basics of release management. TB is released in three versions from three(six) separate HG repositories:
Daily (mozilla/comm-central), Beta (mozilla/comm-beta) and ESR, now at ESR 102 (mozilla/comm-esr102).

In general, if a bug is found in ESR (102) and fixed in Daily (currently at 104), the patch with the fix needs to be backported, also called "uplifted", to ESR. Before that happens, the patch is backported to Beta (currently at 103). Therefore in comment #8 we said that you need to request beta approval, either before or together with ESR approval. ESR approval is generally granted later.

The case of this bug is a little more complicated. The bug was reported for Beta (103) and therefore a beta request must be made.

Let's look at whether ESR 102 is affected. If you try it out, you will see that it is not affected. What happened is this: The Firefox team fixed in bug in FF 103, bug 1766030, something with a download link inside a PDF. While fixing the bug in FF 103, they changed an API (adding another parameter) and that API change broke TB 103 so beta users complained. The Firefox team also marked FF 102 ESR as affected by the original download link bug. If you look at bug 1766030, they haven't backported the fix to FF 102 ESR yet, so no API change has happened in the Mozilla 102 ESR code base. Therefore TB 102 ESR is not yet affected, but it will be affected as soon as the Firefox team also make the change in the Mozilla 102 ESR code base.

A prudent release manager would follow bug 1766030 and as soon as that is fixed in ESR 102, also apply the corresponding TB fix to comm-esr102.

Hopefully this is clear now, don't hesitate to ask if there are further questions.

Comment 13

[Rachel Martin]

Comment on attachment 9283648 [details]
Bug 1777323 - Add missing parameter to internalSave() call. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Bug 1766030
User impact if declined: Users will not be able to View Source > Save As and save embedded images (bug 1777899)
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky): low, just adds the missing parameter

NOTE: This also needs to go to TB 102 ESR as soon as bug 1766030 is also backported.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9283648 [details]
Bug 1777323 - Add missing parameter to internalSave() call. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 103.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/0d9c9367727d

Comment 17

[Peter Barker]

Save Image As... still doesn't save anything in TB 103.0b4

Comment 18

[Bill Falls]

Same here, Thunderbird 103.0b4 (64-bit) on Windows 11 Home, installed just now (July 9). "Save image as..." behaves normally with no error messages but the image does not appear in the destination folder.

Comment 19

[Thomas D. (:thomas8)]

(In reply to Rob Lemley [:rjl] from comment #16)

Thunderbird 103.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/0d9c9367727d

Unfortunately, as others have said, from my own testing this still fails for me on 103.0b4 (64-bit), Win10, with the console error below.
Lasana, can you have another look? I think comment 12 may have helpful insights.
Re-opening looks best way forward - let me know if you prefer something else.

aInitiatingDocument is undefined contentAreaUtils.js:363
    continueSave chrome://global/content/contentAreaUtils.js:363
    internalSave chrome://global/content/contentAreaUtils.js:342
    (Async: promise callback)
    internalSave chrome://global/content/contentAreaUtils.js:334
    saveURL chrome://global/content/contentAreaUtils.js:85
    saveImage chrome://messenger/content/nsContextMenu.js:855
    oncommand chrome://messenger/content/messenger.xhtml:1

Comment 21

[Lasana Murray]

Let's leave this closed and handle "Save image as" in the bug filed for that.

Comment 22

[Rob Lemley [:rjl]]

Comment on attachment 9283648 [details]
Bug 1777323 - Add missing parameter to internalSave() call. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1766030
User impact if declined: Save as functionality will not work
Testing completed (on c-c, etc.): Beta since 103
Risk to taking this patch (and alternatives if risky):
Needs to be uplifted to go with uplift to mozilla-esr102.

Comment 23

[Wayne Mery (:wsmwk)]

Comment on attachment 9283648 [details]
Bug 1777323 - Add missing parameter to internalSave() call. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 24

[Rob Lemley [:rjl]]

Thunderbird 102.3.0:
https://hg.mozilla.org/releases/comm-esr102/rev/5f15709003b8