1778804 - Right-click Save Image As... does not save file

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Peter Barker]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.115 Safari/537.36 OPR/88.0.4412.53

Steps to reproduce:

Select message with an inline image
Right-click on image and select Save Image As...
Save As dialog opens, with default file image001.png in Downloads
Click Save

Actual results:

Dialog closes, but no file is saved

Expected results:

image001.png should be saved in Downloads

Comment 1

[Peter Barker]

This was for TB 103.0b4 on linux kubuntu 20.04

Comment 2

[Thomas D. (:thomas8)]

Thanks Peter for testing and reporting this.

Per Aleca's https://bugzil.la/1777899#c3, this should be a dupe of 1777323, which I have just re-openened because as Peter correctly states (and confirmed by me), this is still broken on TB 103.0b4 where that patch had already landed. Let's see if we can get it fixed there.

Comment 3

[Lasana Murray]

Attachment: Bug 1778804 - Fix "Save Image As" in context menus. r=#thunderbird-reviewers

Comment 4

[Lasana Murray]

Note that if bug 1766030 is uplifted to firefox esr then this will have to be uplifted to 102 also.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fa5d82c4a8eb
Fix "Save Image As" in context menus. r=#thunderbird-reviewers,mkmelin

Comment 8

[Bill Falls]

"Save image as" still fails without an error message in TB 103.0b5 (64-bit) on Windows 11

Comment 9

[Peter Barker]

"Save image as" still fails without an error message in TB 103.0b5 on Linux. Is this still open in one of the bugs labelled as duplicates? I cannot find one which is still open. Bug 1777323 which is one of the duplicates is not a problem in 103.0b5, so resolving that bug has not fixed this one.

Comment 10

[Wayne Mery (:wsmwk)]

Attachment: bug 1778804 tracking info - Screen Shot 2022-07-23 at 10.50.50 AM.png

(In reply to Bill Falls from comment #8)

"Save image as" still fails without an error message in TB 103.0b5 (64-bit) on Windows 11

Yes, that mmakes pefect sense. The tracking section of this bug report shows that it is fixed in version 104 (target milestone), and not fixed in beta 103 (thunderbird103 = affected). When beta moves to version 104 next week then you should see the impact of this fix.

Comment 11

[Rob Lemley [:rjl]]

Comment on attachment 9284987 [details]
Bug 1778804 - Fix "Save Image As" in context menus. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1766030
User impact if declined: Save Image as functionality will not work
Testing completed (on c-c, etc.): Beta since 104
Risk to taking this patch (and alternatives if risky):
Needs to be uplifted to go with uplift to mozilla-esr102.

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9284987 [details]
Bug 1778804 - Fix "Save Image As" in context menus. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 102.3.0:
https://hg.mozilla.org/releases/comm-esr102/rev/4029143de946