1777542 - Double clicking chat message executes first action

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Martin Giger [:freaktechnik]]

As reported in bug 1772767:

double-click on the "Decrypting..." message and that causes the message to be deleted

This is likely a regression from fixing chat message actions, where the code doesn't correctly check that it is being executed from the context menu item.

Comment 1

[Patrick Cloke [:clokep]]

This isn't a regression, it is the default behavior which I forgot about when reviewing the patch, see https://searchfox.org/comm-central/rev/bbad2db99551a14a1a6062a7c6d6b1d9c094cbf7/chat/components/public/prplIMessage.idl#87-95

(The behavior exists so that you could double click a Tweet and do a proper reply to it or something. That's what actions were originally added for.)

Having the first action returned be an implicit default seems not awesome though.

(We really need to kill off the interfaces so we can check a single place for documentation...)

Comment 2

[Martin Giger [:freaktechnik]]

Okay, let's remove this twitter specific behavior then.

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1777542 - Don't execute first message action on chat message double click. r=#thunderbird-reviewers

Comment 4

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/51893323bd50

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 9283811 [details]
Bug 1777542 - Don't execute first message action on chat message double click. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Users might by accident report or redact their matrix chat messages from double clicking. Normally double clicking either selects parts of the message or mentions the author of the message.
Testing completed (on c-c, etc.): Tested on c-c
Risk to taking this patch (and alternatives if risky): Low risk

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9283811 [details]
Bug 1777542 - Don't execute first message action on chat message double click. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 103.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/dd5ffb4e6494

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9283811 [details]
Bug 1777542 - Don't execute first message action on chat message double click. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Users might by accident report or redact their matrix chat messages from double clicking. Normally double clicking either selects parts of the message or mentions the author of the message.
Testing completed (on c-c, etc.): 103.0b3
Risk to taking this patch (and alternatives if risky): Low risk

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9283811 [details]
Bug 1777542 - Don't execute first message action on chat message double click. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 102.0.2:
https://hg.mozilla.org/releases/comm-esr102/rev/a5f0c10863bc