1778514 - Avoid mutating source objects because of "relativeUrl" attribute

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

We are currently maintaining a relativeUrl attribute on source objects from here:
https://searchfox.org/mozilla-central/rev/284187d0a7130d21042beeff0af0627c8e68cacc/devtools/client/debugger/src/reducers/sources.js#356

But that's quite costly as we force cloning the map of all sources and may trigger unexpected state/component updates when maintaining this attribute.

This could easily be computed on-demand and this is only used in one callsite:
https://searchfox.org/mozilla-central/rev/284187d0a7130d21042beeff0af0627c8e68cacc/devtools/client/debugger/src/utils/quick-open.js#55

This will help bug 1777203 by ensuring that source objects are really immutable.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1778514 - [devtools] Avoid mutating source objects because of relative url computation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb5dc073b7e4
[devtools] Avoid mutating source objects because of relative url computation. r=bomsy

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cb5dc073b7e4