Codebase to maintain the SourceTree causes massive hangs
Categories
(DevTools :: Debugger, enhancement)
Tracking
(firefox105 fixed)
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [reminder-test 2022-07-26])
Attachments
(3 files, 1 obsolete file)
See the following profile: https://share.firefox.dev/3bhiXwp
This is easily reproducable when opening the MBT on the debugger against a long running firefox session with many tabs.
The slowdown comes from the SourceTree component.
Each time a new source is notified we reupdate/reprocess the whole again.
That appears to be an issue, especially in the MBT as we display lots of sources.
We should aim at computing the Source Tree data structure only once and update it in an efficient way. That while being careful to avoid as much unecessary updates made to the Redux state and the related React components.
|
Assignee | |
Comment 1•1 month ago
|
||
|
|
Assignee | |
Comment 2•29 days ago
|
||
We are updating more things when selecting a thread than when opening the debugger.
Let's use a unique codepath when it comes to handle a new top level target.
|
|
Assignee | |
Comment 3•29 days ago
|
||
|
|
Assignee | |
Comment 4•28 days ago
|
||
|
|
Assignee | |
Comment 5•20 days ago
|
||
Lastest results from damp:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=49cdf31caeb3887e32ed9b9a16e11d7b0a7dd0cd&originalSignature=4081483&newSignature=4081483&framework=12&originalRevision=ffd60d3590150195b8cbec2dbd8d050ffbb34bc8&page=1&showOnlyConfident=1
A few improvement on browser toolbox tests.
|
||
Updated•19 days ago
|
|
|
Assignee | |
Comment 6•19 days ago
|
||
Multi-platform all mochitests try run:
https://treeherder.mozilla.org/jobs?repo=try&revision=e8a27340020a65cc606b572a36e2435afc97f260
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0aef155c8e55 [devtools] Generate SourceTree data directly from the selectors. r=bomsy https://hg.mozilla.org/integration/autoland/rev/3f3a9b9e332e [devtools] Migrate SourceTree to be based on source actors. r=bomsy
|
||
Comment 8•14 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0aef155c8e55
https://hg.mozilla.org/mozilla-central/rev/3f3a9b9e332e
|
||
Comment 9•13 hours ago
|
||
Comment on attachment 9285015 [details]
Bug 1777203 - [devtools] Unify debugger initialization and thread selection.
Revision D151552 was moved to bug 1783813. Setting attachment 9285015 [details] to obsolete.
Description
•