1778647 - Store source's framework only once, in symbols

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

We are currently duplicated source's framework in symbols and tabs reducers:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/actions/sources/symbols.js#26-29
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/reducers/tabs.js#151

This is uncessary and confusing. And this possibly lead to more state/component updates.

This is mostly used to computed the source icon, where things are quite confusing as we are using symbols and tab's framework... which are the same thing!
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/utils/source.js#503-505
https://searchfox.org/mozilla-central/rev/5e6e08e53ca4f9f62e19bcbae542eef7824641ed/devtools/client/debugger/src/components/shared/SourceIcon.js#35-36

I extented test coverage to better cover the behavior of SourceIcon,
while simplifying a few things around this component by unifying the various places
where we compute the final icon, so that now it is only done by getSourceClassnames
and modifier.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1778647 - [devtools] Store source's framework only once, in symbols.

We are currently duplicated source's framework in symbols and tabs reducers.
This is uncessary and confusing. And this possibly lead to more state/component updates.

This is mostly used to computed the source icon.
I extented test coverage to better cover the behavior of SourceIcon,
while simplifying a few things around this component by unifying the various places
where we compute the final icon, so that now it is only done by getSourceClassnames
and modifier.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da2dde196383
[devtools] Store source's framework only once, in symbols. r=bomsy

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/da2dde196383