1778924 - news.us.Usenet-News.net fails

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Marc Auslander]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

open an nntp mesage

Actual results:

blank screen

Expected results:

open message.
Note that this issue was supposedly fixed by bug 1777439 and, at first, seemed fixed in 102.0.1. But today, its back. Switching off jsmodule again "fixes it".

Comment 1

[Thomas D. (:thomas8)]

Well, per Bug 1777439 Comment 20 it's fixed only for 102.0.2 (not 102.0.1), but Bug 1777439 Comment 21 also states that it's not fixed on 102.0.2. :-/

Comment 2

[Thomas D. (:thomas8)]

2022-07-11_1317_mass-mark-TB102found

Comment 3

[WaltS48 [:walts48]]

Marc,

What news server and is it a text or binary newsgroup?

I'm subscribed to alt.binaries.pictures.scenic on news.us.Usenet-News.net where I see this issue, but don't see it using the alt.comp.software.firefox, a.c.s.seamonkey and a.c.s.thunderbird text groups on nntp.aioe.org.

Any error messages in the error console? Ctrl+Shift+J

Comment 4

[Marc Auslander]

news.us.Usenet-News.net text documents
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgAccountManager.getIncomingServer] NntpUtils.jsm:47
findServer resource:///modules/NntpUtils.jsm:47
NntpChannel resource:///modules/NntpChannel.jsm:34
newChannel resource:///modules/NntpProtocolHandler.jsm:31
DisplayMessage resource:///modules/NntpMessageService.jsm:37
makeActive chrome://messenger/content/messageDisplay.js:414
makeActive chrome://messenger/content/folderDisplay.js:1827
openTab chrome://messenger/content/mailTabs.js:392
openTab chrome://messenger/content/tabmail.js:975
displayMessages resource:///modules/MailUtils.jsm:232
MsgOpenSelectedMessages chrome://messenger/content/mailWindowOverlay.js:2506
ThreadPaneDoubleClick chrome://messenger/content/threadPane.js:246
ThreadPaneOnClick chrome://messenger/content/threadPane.js:75
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMailNewsUrl.loadURI] NntpMessageService.jsm:37
DisplayMessage resource:///modules/NntpMessageService.jsm:37
makeActive chrome://messenger/content/messageDisplay.js:414
makeActive chrome://messenger/content/folderDisplay.js:1827
openTab chrome://messenger/content/mailTabs.js:392
openTab chrome://messenger/content/tabmail.js:975
displayMessages resource:///modules/MailUtils.jsm:232
MsgOpenSelectedMessages chrome://messenger/content/mailWindowOverlay.js:2506
ThreadPaneDoubleClick chrome://messenger/content/threadPane.js:246
ThreadPaneOnClick chrome://messenger/content/threadPane.js:75

Comment 5

[Ping Chen [:rnons] (away)]

Thanks, will make a fix later.

Comment 6

[Ping Chen [:rnons] (away)]

Can you go to the Config Editor, search for hostname? See if you happen to have more than one server with news.us.Usenet-News.net as the hostname

Comment 7

[Marc Auslander]

Two entries. I only have one account for news.us.Usenet-News.net in the account settings.

Comment 8

[WaltS48 [:walts48]]

(In reply to Ping Chen (:rnons) from comment #6)

Can you go to the Config Editor, search for hostname? See if you happen to have more than one server with news.us.Usenet-News.net as the hostname

Two entries here for the one account.

mail.server.server16.hostname news.us.usenet-news.net
mail.server.server8.hostname news.us.Usenet-News.net

Comment 9

[Ping Chen [:rnons] (away)]

Attachment: Bug 1778924 - Put getIncomingServer in try..catch block to fix loading nntp article. r=mkmelin

Fix the case when two servers have the same hostname.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/be9500248a41
Put getIncomingServer in try..catch block to fix loading nntp article. r=mkmelin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0e708608b414
follow-up, fix wrong variable for logging. rs=eslint DONTBUILD

Comment 12

[newsfan]

Looks like this broke comm/mailnews/import/test/unit/test_winmail.js.

Comment 13

[Marc Auslander]

Something I don't understand is going on here. Why to I have two entries? In fact, if I blow away one, and then try the jsmodule implementation, only when I try to open a document does the second entry reappear - namely
mail.server.server19.hostname news.us.usenet-news.net
mail.server.server19.type nntp
and of course the document doesn't open.

Comment 14

[Ping Chen [:rnons] (away)]

(In reply to newsfan from comment #12)

Looks like this broke comm/mailnews/import/test/unit/test_winmail.js.

The test was broken by bug 1745033, I'm looking into it.

(In reply to Marc Auslander from comment #13)

Something I don't understand is going on here. Why to I have two entries? In fact, if I blow away one, and then try the jsmodule implementation, only when I try to open a document does the second entry reappear - namely
mail.server.server19.hostname news.us.usenet-news.net
mail.server.server19.type nntp
and of course the document doesn't open.

The new server is created by https://searchfox.org/comm-central/rev/c24995178e8fe0cc7213c8a2095d167c0ad8d56f/mailnews/news/src/NntpChannel.jsm#40-41.
We have a feature to create a server on the fly to load a news url. But that should only happen when the server is not already in your profile (e.g. click a news url you received), don't know why it occurs to you. Perhaps I should do a case-insensitive comparing in https://searchfox.org/comm-central/rev/c24995178e8fe0cc7213c8a2095d167c0ad8d56f/mailnews/news/src/NntpUtils.jsm#47

Comment 15

[Marc Auslander]

Case may be the issue.
The configured entry is news.us.Usenet-News.net while the created entry is all lower case.

Comment 16

[Marc Auslander]

I have verified that changing the configured server to all lower case eliminates the issue. A second server entry is NOT created and access works.

Comment 17

[WaltS48 [:walts48]]

(In reply to Marc Auslander from comment #16)

I have verified that changing the configured server to all lower case eliminates the issue. A second server entry is NOT created and access works.

So, I just updated Daily to Build ID 20220718104651, and my a.b.p.scenic newsgroup works! I can read messages again.

In the Config Editor, I see two Hostname entries in lower case, and one with news.us.Usenet-News.net.

Are you saying I should remove the account and recreate it using news.us.usenet-news.net?

I may just leave it since it started working.

Comment 18

[Ping Chen [:rnons] (away)]

(In reply to Marc Auslander from comment #16)

I have verified that changing the configured server to all lower case eliminates the issue. A second server entry is NOT created and access works.

Thanks, I changed to do case-insensitive in bug 1779865 as well.

Comment 19

[Ping Chen [:rnons] (away)]

Comment on attachment 9285582 [details]
Bug 1778924 - Put getIncomingServer in try..catch block to fix loading nntp article. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: Can not load news article for some users due to two entries of the same server
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Comment 20

[Ping Chen [:rnons] (away)]

Attachment: 1778924-esr102.patch

Rebased to esr102.

[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: Can not load news article for some users due to two entries of the same server
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9287810 [details] [diff] [review]
1778924-esr102.patch

[Triage Comment]
Approved for esr102

Comment 22

[Rob Lemley [:rjl]]

Thunderbird 102.1.1:
https://hg.mozilla.org/releases/comm-esr102/rev/401ec5321894