Folder properties dialog too small for translations/localizations like Finnish, Russian etc.
Categories
(Thunderbird :: Theme, defect, P4)
Tracking
(thunderbird_esr102+ fixed, thunderbird103 fixed)
People
(Reporter: tikkanen, Assigned: henry-x)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files, 2 obsolete files)
|
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr102+
|
Details | Review |
|
36.32 KB,
image/png
|
Details |
Screenshot of the problem
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:103.0) Gecko/20100101 Firefox/103.0
Steps to reproduce:
- Right click any folder
- Select "Ominaisuudet" ("Properties")
Actual results:
Dialog that opens is too small for content.
I guess that problem is that title fields are longer than in original (English) version.
Expected results:
Dialog should be resized for the content.
|
Reporter | |
Comment 1•3 years ago
|
||
|
||
Comment 2•3 years ago
|
||
Ouch! Thanks Tuomo.
Richard, if it's not your territory, you can ask Henry I guess for auto-sizing the dialog.
|
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 3•3 years ago
|
||
Probably from bug 1703164. A width of 570px was set on the window https://hg.mozilla.org/comm-central/rev/78d2559050ab#l2.29
I think removing the width and height from the toplevel <html> and putting a max-width: 570px on the xul:description elements might work better.
|
||
Updated•3 years ago
|
|
||
Comment 4•3 years ago
|
||
(In reply to Henry Wilkes (they/them) [:henry] from comment #3)
Probably from bug 1703164. A width of
570pxwas set on the window https://hg.mozilla.org/comm-central/rev/78d2559050ab#l2.29I think removing the
widthandheightfrom the toplevel<html>and putting amax-width: 570pxon thexul:descriptionelements might work better.
Tried this and it doesn't work, at least on Windows there only a minimal square is shown.
Henry, could you look if you find a solution? I played also with window.sizeToContent(); but this failed too for me.
|
|
Assignee | |
Comment 6•3 years ago
|
||
|
||
Updated•3 years ago
|
|
||
Comment 7•3 years ago
|
||
|
|
Reporter | |
Comment 8•3 years ago
|
||
Reattaching the original screenshot as it got deleted accidentally.
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/40e08e3440e4
Don't size the folderProps dialog. r=Paenglab,mkmelin
|
|
||
Updated•3 years ago
|
|
|
||
Comment 12•3 years ago
|
||
Let's uplift this soon to avoid getting duplicates for more languages...
|
|
||
Comment 13•3 years ago
|
||
Comment on attachment 9284956 [details]
Bug 1778958 - Don't size the folderProps dialog. r=Paenglab
[Approval Request Comment]
Regression caused by (bug #): bug 1703164
User impact if declined: Folder property sizing issues
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): it is very safe
|
||
Comment 14•3 years ago
|
||
Comment on attachment 9284956 [details]
Bug 1778958 - Don't size the folderProps dialog. r=Paenglab
[Triage Comment]
Approved for beta
|
||
Comment 15•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 103.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/73b7006a15d6
|
|
||
Comment 16•3 years ago
|
||
Comment on attachment 9284956 [details]
Bug 1778958 - Don't size the folderProps dialog. r=Paenglab
[Triage Comment]
Approved for esr102
|
|
||
Comment 17•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 102.1.0:
https://hg.mozilla.org/releases/comm-esr102/rev/99ccd4ea0fe7
Description
•