1779119 - Render the seek bar and rewind the video via seek bar slider

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, task)

Description

[Ania]

Attachment: pip seek bar and rewind.png

Folder with designs

User story
As a user, I want to be able to rewind PiP video, so I can control the pace of my experience without switching from my primary task.

Acceptance Criteria

1. I can rewind the video by moving a seek bar slider along seek bar.
2. Pre-buffered area can be distinguished from the area of the video that hasn't been pre-buffered.

UI spec for the rewind slider

1. colors used

• already played: background: #FFFFFF;
• buffering: #FFFFFF, opacity: 0.5
• non-buffered: #FFFFFF, opacity: 0.3

2. seek bar slider colors and sizes

• inner circle: #BFBFC9, 8x8 px
• outer circle: #FFFFFF, 14x14 px

3. left and right padding (distance between the end of the seek bar and the edge of the video): 24 px

4. padding from seek bar to controls underneath it (play, rewind, etc): 13 px

5. padding from seek bar slider to controls: 8 px

6. padding from the subtitles box above the seek bar: 12 px

7. border radius for the ends of the bar: 10px

8. height of the seek bar: 14px

9. color specification for high-contrast mode

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Looks like somebody has started an effort to do this in bug 1579645.

Was there somebody already slated to work on this? If so, we should probably coordinate with the effort already underway in bug 1579645 to avoid duplicate effort.

Comment 2

[Luc]

This video progress bar looks prettier than mine.
Who can check code to confirm it and to be pushed later?

Comment 3

[Ania]

Mike, thank you for tagging me on this.
Commented in a related ticket.

Luc, thank you for working on this!

Comment 4

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1779119 - Add video scrubber to PiP window. r=#pip-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dddc130f67e
Add video scrubber to PiP window. r=pip-reviewers,kpatenio,cmkm

Comment 6

[Cristian Tuns]

Backed out for causing documentation failures

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7ed6d2b02fb
Add video scrubber to PiP window. r=pip-reviewers,kpatenio,cmkm

Comment 8

[Sylvestre Ledru [:Sylvestre]]

here is the error - seems to be sphinx-js:

[task 2022-11-22T02:41:17.947Z] #   reading sources... [ 88%] toolkit/components/pictureinpicture/pictureinpicture/player-api
[task 2022-11-22T02:41:17.947Z] # Loaded extensions:
[task 2022-11-22T02:41:17.947Z] #   sphinx.ext.mathjax (4.3.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx/ext/mathjax.py
[task 2022-11-22T02:41:17.947Z] #   sphinxcontrib.applehelp (1.0.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinxcontrib/applehelp/__init__.py
[task 2022-11-22T02:41:17.947Z] #   sphinxcontrib.devhelp (1.0.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinxcontrib/devhelp/__init__.py
[task 2022-11-22T02:41:17.947Z] #   sphinxcontrib.htmlhelp (2.0.0) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinxcontrib/htmlhelp/__init__.py
[task 2022-11-22T02:41:17.947Z] #   sphinxcontrib.serializinghtml (1.1.5) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinxcontrib/serializinghtml/__init__.py
[task 2022-11-22T02:41:17.947Z] #   sphinxcontrib.qthelp (1.0.3) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinxcontrib/qthelp/__init__.py
[task 2022-11-22T02:41:17.947Z] #   alabaster (0.7.12) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/alabaster/__init__.py
[task 2022-11-22T02:41:17.947Z] #   myst_parser (0.16.1) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/myst_parser/__init__.py
[task 2022-11-22T02:41:17.947Z] #   sphinx.ext.autodoc.preserve_defaults (1.0) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx/ext/autodoc/preserve_defaults.py
[task 2022-11-22T02:41:17.947Z] #   sphinx.ext.autodoc.type_comment (4.3.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx/ext/autodoc/type_comment.py
[task 2022-11-22T02:41:17.948Z] #   sphinx.ext.autodoc (4.3.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx/ext/autodoc/__init__.py
[task 2022-11-22T02:41:17.948Z] #   sphinx.ext.doctest (4.3.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx/ext/doctest.py
[task 2022-11-22T02:41:17.948Z] #   sphinx.ext.graphviz (4.3.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx/ext/graphviz.py
[task 2022-11-22T02:41:17.948Z] #   sphinx.ext.napoleon (4.3.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx/ext/napoleon/__init__.py
[task 2022-11-22T02:41:17.948Z] #   sphinx.ext.todo (4.3.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx/ext/todo.py
[task 2022-11-22T02:41:17.948Z] #   mozbuild.sphinx (unknown version) from /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/sphinx.py
[task 2022-11-22T02:41:17.948Z] #   sphinx_js (unknown version) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/__init__.py
[task 2022-11-22T02:41:17.948Z] #   sphinxcontrib.mermaid (4.3.2) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinxcontrib/mermaid.py
[task 2022-11-22T02:41:17.948Z] #   sphinx_copybutton (0.5.0) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_copybutton/__init__.py
[task 2022-11-22T02:41:17.948Z] #   sphinx_markdown_tables (<module 'sphinx_markdown_tables.__version__' from '/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_markdown_tables/__version__.py'>) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_markdown_tables/__init__.py
[task 2022-11-22T02:41:17.948Z] #   sphinx_panels (0.6.0) from /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_panels/__init__.py
[task 2022-11-22T02:41:17.948Z] #   bzlink (unknown version) from /builds/worker/checkouts/gecko/docs/_addons/bzlink.py
[task 2022-11-22T02:41:17.948Z]     results = StateMachineWS.run(self, input_lines, input_offset,
[task 2022-11-22T02:41:17.948Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/statemachine.py", line 241, in run
[task 2022-11-22T02:41:17.948Z]     context, next_state, result = self.check_line(
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/statemachine.py", line 459, in check_line
[task 2022-11-22T02:41:17.949Z]     return method(match, context, next_state)
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/parsers/rst/states.py", line 2769, in underline
[task 2022-11-22T02:41:17.949Z]     self.section(title, source, style, lineno - 1, messages)
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/parsers/rst/states.py", line 327, in section
[task 2022-11-22T02:41:17.949Z]     self.new_subsection(title, lineno, messages)
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/parsers/rst/states.py", line 393, in new_subsection
[task 2022-11-22T02:41:17.949Z]     newabsoffset = self.nested_parse(
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/parsers/rst/states.py", line 281, in nested_parse
[task 2022-11-22T02:41:17.949Z]     state_machine.run(block, input_offset, memo=self.memo,
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/parsers/rst/states.py", line 196, in run
[task 2022-11-22T02:41:17.949Z]     results = StateMachineWS.run(self, input_lines, input_offset)
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/statemachine.py", line 241, in run
[task 2022-11-22T02:41:17.949Z]     context, next_state, result = self.check_line(
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/statemachine.py", line 459, in check_line
[task 2022-11-22T02:41:17.949Z]     return method(match, context, next_state)
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/parsers/rst/states.py", line 2342, in explicit_markup
[task 2022-11-22T02:41:17.949Z]     nodelist, blank_finish = self.explicit_construct(match)
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/parsers/rst/states.py", line 2354, in explicit_construct
[task 2022-11-22T02:41:17.949Z]     return method(self, expmatch)
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/parsers/rst/states.py", line 2096, in directive
[task 2022-11-22T02:41:17.949Z]     return self.run_directive(
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/docutils/parsers/rst/states.py", line 2146, in run_directive
[task 2022-11-22T02:41:17.949Z]     result = directive_instance.run()
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx/domains/__init__.py", line 286, in run
[task 2022-11-22T02:41:17.949Z]     return super().run()
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/directives.py", line 60, in run
[task 2022-11-22T02:41:17.949Z]     return AutoClassRenderer.from_directive(self, app).rst_nodes()
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/renderers.py", line 76, in rst_nodes
[task 2022-11-22T02:41:17.949Z]     rst = self.rst(self._partial_path,
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/renderers.py", line 102, in rst
[task 2022-11-22T02:41:17.949Z]     return template.render(**self._template_vars(dotted_name, full_path, doclet))
[task 2022-11-22T02:41:17.949Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/renderers.py", line 245, in _template_vars
[task 2022-11-22T02:41:17.949Z]     members=self._members_of(full_path,
[task 2022-11-22T02:41:17.950Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/renderers.py", line 311, in _members_of
[task 2022-11-22T02:41:17.950Z]     return '\n\n'.join(
[task 2022-11-22T02:41:17.950Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/renderers.py", line 312, in <genexpr>
[task 2022-11-22T02:41:17.950Z]     rst_for(doclet) for doclet in doclets_to_include(include)
[task 2022-11-22T02:41:17.950Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/renderers.py", line 267, in rst_for
[task 2022-11-22T02:41:17.950Z]     return renderer(self._directive, self._app, arguments=['dummy']).rst(
[task 2022-11-22T02:41:17.950Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/renderers.py", line 102, in rst
[task 2022-11-22T02:41:17.950Z]     return template.render(**self._template_vars(dotted_name, full_path, doclet))
[task 2022-11-22T02:41:17.950Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/renderers.py", line 222, in _template_vars
[task 2022-11-22T02:41:17.950Z]     params=self._formal_params(doclet),
[task 2022-11-22T02:41:17.950Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/docs/lib/python3.9/site-packages/sphinx_js/renderers.py", line 169, in _formal_params
[task 2022-11-22T02:41:17.950Z]     name = param['name'].split('.')[0]

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b7ed6d2b02fb