1779427 - Turn on Firefox View feature tour by updating default value of browser.firefoxView.featureTour

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

Once the Firefox View feature tour is ready for users, set the default value of browser.firefoxView.featureTour to:
{"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"","complete":false}
which indicates the user has not seen the feature tour and provides the id for the current default message for the Firefox View tour..

Comment 2

[Ed Lee :Mardak]

I believe the pref value wants to be {"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"FEATURE_CALLOUT_1","complete":false}

This can happen anytime during 106 nightly as the callout will only be shown when someone gets to firefox view anyway.

Comment 3

[Emily McMinn :emcminn]

Attachment: Bug 1779427 - Turn on Firefox View feature tour by default r=mviar

Comment 4

[Meg Viar [:mviar]]

Make sure that TypeError: window.AWGetFeatureConfig is not a function error doesn't appear in console once the new default pref value is set (this was an issue when loading with the "off" value, but shouldn't be present with the updated value).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44c1ce2f6854
Turn on Firefox View feature tour by default r=mviar

Comment 6

[Cristian Tuns]

Backed out for causing mochitest failures on browser_setup_state.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_setup_state.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

And also this: https://treeherder.mozilla.org/logviewer?job_id=388603613&repo=autoland

Comment 7

[Emily McMinn :emcminn]

This failure looks like an existing intermittent; (I found another backout for the same issue here) I wasn't able to reproduce it locally. I'm currently running another try push and if that comes back ok, I'll try landing again.

Comment 8

[Cristian Tuns]

Maybe this: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=b8ZOEjv8SG-RHrKU7jT_Xg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=676ab9a6746eab17035a90e83b6e85e86dafbc67&searchStr=Windows%2C10%2Cx86%2C2004%2CWebRender%2Cdebug%2CMochitests%2Ctest-windows10-32-2004-qr%2Fdebug-mochitest-browser-chrome%2Cbc2 will help you in any way, because this is perma and it has the Assertion failure

Comment 10

[Emily McMinn :emcminn]

I've been unable to duplicate the intermittent & it's being actively worked on in other patches, so I'm going to attempt landing this again.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c739e6f1b109
Turn on Firefox View feature tour by default r=mviar

Comment 12

[Iulian Moraru]

Backed out for causing mochitest failures.

Push with failures

Failure log for when it first fails on browser_setup_state.js
Failure log for when it first fails with assertion

Backout link

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa77f15a38d9
Turn on Firefox View feature tour by default r=mviar

Comment 14

[Emily McMinn :emcminn]

@mviar has done some work knocking down intermittents for Firefox view, so I've rebased on top of those fixes and that will hopefully solve this.

Comment 15

[Narcis Beleuzu [:NarcisB]]

Backed out for assertion failure on DOMJSProxyHandler.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/65b67c0fb8c98d31455e32f5310664302cb9ccbf
Log link: https://treeherder.mozilla.org/logviewer?job_id=389203610&repo=autoland&lineNumber=4509

Comment 16

[Emily McMinn :emcminn]

Based on this existing intermittent from 5 months ago, I don't think this failure was caused by the pref flip. Are we ok to land again with that documented?

Comment 17

[Narcis Beleuzu [:NarcisB]]

It is ok to re-land it but if it will perma fail, we will have to back it out again

Comment 18

[Ed Lee :Mardak]

(In reply to Narcis Beleuzu [:NarcisB] from comment #15)

Backed out for assertion failure on DOMJSProxyHandler.cpp

Suspiciously similar to bug 1652531 which has an underlying bug 1543537 from using defineLazyPreferenceGetter and worked around with bug 1703083 doing Cu.getWeakReference(document)

mviar is probably fixing this as part of bug 1788231 https://phabricator.services.mozilla.com/D156203#inline-862635

Comment 19

[Ed Lee :Mardak]

Looks like the workaround from comment 18 is necessary? These two pushes differ only with document vs docWeak.get()

https://treeherder.mozilla.org/jobs?repo=try&fromchange=e41b23ded4d434c93a1aafd608afdb32f9233f52&tochange=3d22c359f6261c507ebb1f70a6ce64e7f6ec99b8

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2527c3dc7c4a
Turn on Firefox View feature tour by default r=mviar

Comment 21

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2527c3dc7c4a

Comment 22

[Alice Varro [avarro], Ecosystem QA]

I have verified this enhancement and I can confirm that the "browser.firefox-view.feature-tour" pref has the " {"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"FEATURE_CALLOUT_1","complete":false}" default value.

• The Firefox view feature tour is automatically shown when navigating to the Firefox View page.

Verified using the latest Firefox Nightly (106.0a1 Build ID - 20220911214030) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.