Closed Bug 1780311 Opened 2 years ago Closed 7 months ago

"Membership Rewards" image fails to paint on initial logged-in view at SFCU (Stanford Federal Credit Union), until user does something to cause a repaint

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1805599
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- wontfix
firefox102 --- wontfix
firefox103 --- wontfix
firefox104 --- wontfix
firefox105 --- wontfix
firefox106 --- wontfix
firefox127 --- fixed

People

(Reporter: dholbert, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR, which unfortunately requires a username/password for SFCU (a credit union/bank):

  1. Log in at https://www.sfcu.org/
  2. Once the landing page finishes loading, look at the "Membership Rewards" icon near the top center. If the icon shows up, reload the page (Ctrl+R)

ACTUAL RESULTS:
Usually, the icon is missing at first load; however, if I force a repaint by switching windows or clicking a blank space on the Firefox toolbar (between the URL bar and the bookmark menu), then the icon loads.

EXPECTED RESULTS:
Icon should paint without needing manual user interaction.

REGRESSION RANGE (from running mozregression with fission.autostart:true[1]):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=56a1fce20849e569b75856301c801f89a0d6e0b9&tochange=afed7ee7a5dcee09542f3157224a54057527d842

Looks like a regression from Bug 1711061.

[1] On my system at least, it looks like fission is required to trigger this bug. My first attempt at mozregression narrowed in on a several-day-range that included the "enable fission on non-android systems" commit (from bug 1732358), so at that point I bailed and restarted mozregression with fission force-enabled, and I got a somewhat-older regression range with bug 1711061 as the apparent culprit.

The HTML snippet in question for the relevant section of the page is:

<div style="text-align: center; cursor: pointer;" class="membership_rewards css-vurnku">
<div class="h(6x) h(4) pad-t(1) css-vurnku">
<img src="https://sdk-cdn.onlineaccess1.com/sdk-nginx-prd/sdkcdn/q2sdk-5105-olbnavigation-qsdk-2022-07-19_010903/tectonWidget_top_dashboard2/assets/ICON_membership_rewards.svg" class="css-9taffg">
</div>
<div class="pad-t(2) css-vurnku">
<span style="color: var(--tct-gray-d2);" class="css-vurnku">Membership Rewards</span>
</div>
</div>

This reduced testcase isn't sufficient to trigger the bug, but hopefully it gives a little insight (e.g. we're dealing with an <img> element that's pointing to some SVG).

Going down a short rabbit-hole from bug 1711061's related bugs, I do see bug 1773355 which seems possibly-related (both bugs are about missing SVG images). Bug 1773355 comment 7 mentioned image.svg.blob-image helps there, and I confirmed that setting that pref to true seems to fix this bug here as well. So I'll mark this as a dependency of (hopefully-will-be-fixed-by) bug 1673653 which I think (?) is tracking our ability to ship that pref-enabling.

Here's a screencast showing the bug (only showing the relevant "header" part of the page, to protect personal info).

at t=0s, the screencast is showing the "steady state" expected rendering of the page. I immediately reload
at t=5s, the bug is visible -- the page has finished loading but is missing the "Membership Rewards" icon.
(The bug persists [i.e. no image] for most of the screencast after this point, until near the very end:)
at t=15s, I click some blank space on the Firefox toolbar (to the left of the URL bar), and this finally prompts us to paint the image.

Set release status flags based on info from the regressing bug 1711061

:aosmond, since you are the author of the regressor, bug 1711061, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(aosmond)

(In reply to Daniel Holbert [:dholbert] from comment #0)

Going down a short rabbit-hole from bug 1711061's related bugs, I do see bug 1773355 which seems possibly-related (both bugs are about missing SVG images).

I believe bug 1773355 happens because the svg image is required to be rasterized at too big of a size, which doesn't seem like it would happen in this testcase.

Set release status flags based on info from the regressing bug 1711061

Severity: -- → S4
Priority: -- → P3

I think this is the same issue as bug 1805599.

Depends on: 1805599

No need to ni aosmond when the patch in bug 1805599 should fix this.

Flags: needinfo?(aosmond)
No longer depends on: wr-investigate-glitch

Bug 1805599 landed which I think should fix this. Could you re-test if you get a chance?

Flags: needinfo?(dholbert)

Yup, this is fixed - thanks!

I tested before & after accepting the latest Nightly update (Nightly for 2024-05-01 vs 2024-05-02), with my regular browsing profile.

2024-05-01 reproduces the bug
2024-05-02 does not reproduce the bug

Status: NEW → RESOLVED
Closed: 7 months ago
Duplicate of bug: 1805599
Flags: needinfo?(dholbert)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: