1781437 - [macOS] Master / Popup windows font text shouldn't be black with dark theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Nicolas Mandil (:NicolasWeb)]

Steps to reproduce:
1. Start Thunderbird >= 102.0.3
2. Set the dark theme
3. Set a main password in Settings > Privacy
4. Close & reopen Thunderbird

Actual results:
The text of master password pop-up window is black on a black background

Expected results:
The text of master password pop-up window should be "white", as anywhere in TB dialogs with dark theme

Tested on macOS 10

Comment 1

[Nicolas Mandil (:NicolasWeb)]

This bug is a follow-up of bug 1776615

Comment 2

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB master password and save draft pop-up windows macOS 10.13.jpeg

It seems it affect all pop-ups windows

Comment 3

[Nicolas Mandil (:NicolasWeb)]

Wayne, may I ask what I can do to help that bug go forward please ?

I changed the title, because it's not only the Master/Primary password popup window that is affected, but all popups windows.
This bug make them really hard to read.
This bug still exist today in Daily.

Comment 4

[Wayne Mery (:wsmwk)]

I cannot reproduce with beta or daily

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug 1781437 - Set on dialogs with dark theme the text color too. r=aleca

Comment 6

[Richard Marti (:Paenglab)]

Nicolas, could you try this build https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/L02fMkXdS2y1mpQax4BWow/runs/0/artifacts/public/build/target.dmg ?

Please use a different/new profile because this is a TB 107 build.

Comment 7

[Nicolas Mandil (:NicolasWeb)]

Okay, it's fixed while trying the build you gave me with a new profile.
Thanks you a lot :))
Have a good day.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/88f11c6f1606
Set on dialogs with dark theme the text color too. r=aleca

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9297981 [details]
Bug 1781437 - Set on dialogs with dark theme the text color too. r=aleca

[Approval Request Comment]
User impact if declined: unreadable dialogs on older macOS with dark themes
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): Low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9297981 [details]
Bug 1781437 - Set on dialogs with dark theme the text color too. r=aleca

[Triage Comment]
Approved for esr102

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 102.4.1:
https://hg.mozilla.org/releases/comm-esr102/rev/2f7988f22858