Closed Bug 1782858 Opened 12 days ago Closed 11 days ago

Make the fix for bug 1782623 work better on Windows as well.

Categories

(Core :: Widget: Win32, defect)

defect

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

In bug 1782623, I made color-scheme propagate from the page, to make (among other things) scrollbar theming match the content. This has an interesting edge-case on Windows where color-scheme isn't honored by menu backgrounds and so on, where you can get a dark menu but light scrollbars.

Attached file Test-case.

On dark mode, you get dark popup in both cases, while the left one should probably be light.

This matches what Linux and macOS do, and that allows the fix for bug 1782623
to work on Windows for unstyled selects.

This also simplifies the CSS (though it adds a new system color which is a bit
more annoying). I filed https://github.com/w3c/csswg-drafts/issues/7561 to
propose adding a more generic way to do this in the future (not just for
Firefox).

Attachment #9288218 - Attachment mime type: text/plain → text/html
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/747d3cad1bad
Make color-scheme affect Windows' non-native menus. r=desktop-theme-reviewers,dao
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/26d727959201
Fix a test expectation for a test that was passing by chance.
Status: NEW → RESOLVED
Closed: 11 days ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Regressions: 1783566
You need to log in before you can comment on or make changes to this bug.