1782858 - Make the fix for bug 1782623 work better on Windows as well.

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

In bug 1782623, I made color-scheme propagate from the page, to make (among other things) scrollbar theming match the content. This has an interesting edge-case on Windows where color-scheme isn't honored by menu backgrounds and so on, where you can get a dark menu but light scrollbars.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case.

On dark mode, you get dark popup in both cases, while the left one should probably be light.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1782858 - Make color-scheme affect Windows' non-native menus. r=mconley,Gijs

This matches what Linux and macOS do, and that allows the fix for bug 1782623
to work on Windows for unstyled selects.

This also simplifies the CSS (though it adds a new system color which is a bit
more annoying). I filed https://github.com/w3c/csswg-drafts/issues/7561 to
propose adding a more generic way to do this in the future (not just for
Firefox).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/747d3cad1bad
Make color-scheme affect Windows' non-native menus. r=desktop-theme-reviewers,dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26d727959201
Fix a test expectation for a test that was passing by chance.

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/747d3cad1bad
https://hg.mozilla.org/mozilla-central/rev/26d727959201