1793307 - The searchbar popup is missing a border in HCM again

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Itiel]

Bug 1782858 regressed a part of bug 1770210, basically --menu-border-color doesn't exist anymore.
Replacing it with --arrowpanel-border-color here:
https://searchfox.org/mozilla-central/rev/462f51927aaeb97447dd2a9f347ca42b1e6f9fa3/browser/themes/shared/searchbar.css#178
should fix it.

(Also I think the @media here can go away, not sure why I thought it was needed back in the day (or maybe it's not needed anymore -- not sure):
https://searchfox.org/mozilla-central/rev/462f51927aaeb97447dd2a9f347ca42b1e6f9fa3/browser/themes/shared/urlbarView.css#870 )

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1782858

:emilio, since you are the author of the regressor, bug 1782858, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Nice catch!

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1793307 - Fix search panel border color on win10. r=Itiel

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72025dbe3f1c
Fix search panel border color on win10. r=Itiel,desktop-theme-reviewers

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/72025dbe3f1c

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9296890 [details]
Bug 1793307 - Fix search panel border color on win10. r=Itiel

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial one-liner CSS fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9296890 [details]
Bug 1793307 - Fix search panel border color on win10. r=Itiel

Approved for 106.0b8, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/bc1442178327

Comment 10

[Ciprian Georgiu, Desktop QA]

I've reproduced this issue on Win 10, using an affected Nightly build 107.0a1 (2022-10-01).

The issue is verified as fixed on the latest builds, Beta 106.0b8 and Nightly 107.0a1 (20221005094233).