1782962 - Add telemetry for dom.popup_allowed_events being modified by user manually

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Edgar Chen [:edgar]]

In bug 1656444, we would like to move popup blocker to new user activation model, and it is not clear whether we should continue support configurable event list.

There is a known use case that user might set dom.popup_allowed_events to empty string to always block the popup (even within a valid user activaion), see bug 1230833 and bug 1782382. But not sure how widely it is used, this bug is filed to add some telemetry to get some data.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Copying the notes when talking with Edgar -
More specific, we want to cover these two cases:

1. add the usage count of the preference which was set to empty string
2. add the usage count when users customize the preference.

Comment 2

[Edgar Chen [:edgar]]

We could add dom.popup_allowed_events into https://searchfox.org/mozilla-central/rev/d436104fc6c31677b08a851796bead25153be699/toolkit/components/telemetry/app/TelemetryEnvironment.sys.mjs#209 with RECORD_PREF_VALUE.

Comment 3

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1782962 - Add telemetry for dom.popup_allowed_events pref

It can be manually added to control what events allow popups.

If the popup blocker is rewritten to use the new user activation model
and this is relied upon it would be a blocker (needed to be implemented
in the new model).

Comment 4

[Oliver Medhurst [:canadahonk]]

Attachment: Data collection review form

Comment 5

[Chris H-C :chutten]

Comment on attachment 9357450 [details]
Data collection review form

The method of collection (userPrefs) does not support automated expiry nor automatic documentation. Documentation must be manually added to environment.rst and referenced in the data review request. The collection is permanent and must have an individual responsible for its ongoing use.

Comment 6

[Oliver Medhurst [:canadahonk]]

Attachment: Data collection review form 2

Updated form to change how long the data will be collected. Also added pref to environment.rst in patch.

Comment 7

[Chris H-C :chutten]

Comment on attachment 9358092 [details]
Data collection review form 2

PRELIMINARY NOTES:
The documentation for this data collection can be found here, not necessarily in the stated places in the answer to Q6

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Edgar Chen is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ba44fb4eeaf
Add telemetry for dom.popup_allowed_events pref r=edgar,chutten

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9ba44fb4eeaf