1782382 - [NSFW] "dom.popup_allowed_events" no longer able to strictly block pop-ups

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[u710971]

Steps to reproduce:

Go about:config
Set "dom.popup_allowed_events" to blank
Visit the following page
https://streamtape.com/e/kgg1o6jpeJSPoe/?autostart=true
Close out the initial nsfw ads/overlays if any
Now rapidly click the purple play button keep doing it until new-window popup appears

Actual results:

New-window popup appears after clicking on the video multiple times.

Expected results:

No matter how many times i keep clicking anywhere on the video there should be no popups ever.

I also tested with an older version of Firefox (83.0) and the behavior is completely superior to newer Firefox versions, the popups are all consistently blocked, as long as "dom.popup_allowed_events" is set to blank.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Edgar Chen [:edgar]]

I think it is because of the changes in bug 1733052 which allows opening a popup within a valid transient user activation. So I guess in some case the webpage tries to open a popup asynchronously after use click the page, in this case we don't check the "dom.popup_allowed_events". In long-term, we would like to move popup blocker to follow the user activation defined in spec, which will be a bit tricky to continues support allow-event-list (bug 1733062), for the special case, i.e. set to empty string, maybe we could consider adding a another way to enable "always-block-popup" mode if it is widely used by users (bug 1782962).

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1733052

Comment 4

[u710971]

https://addons.mozilla.org/en-US/firefox/addon/popup-blocker-ultimate/

This pop-up blocker add-on is affected in the same exact way, before it used to be able to block all pop-ups similar to "dom.popup_allowed_events"
but now it no longer is able to on these newer Firefox versions, it lets popups through.

https://addons.mozilla.org/en-US/firefox/addon/popup-blocker-ultimate/
That's 60,000+ users already for your stats.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1733052

Comment 7

[Hsin-Yi Tsai (she/her) away [:hsinyi]]

It depends on more investigation, e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1782962