1783887 - [Colorway Closet] Colorways modal is displayed minimized with unnecessary scrolling bar on macOS

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Found in

• Firefox 105.0a1

Affected versions

• Firefox 105.0a1

Affected platforms

• macOS 11.6

Preconditions
In about:config set:
"browser.theme.colorway-closet" to true
"browser.tabs.firefox-view" to true

Steps to reproduce

1. Open "Colorways closet" from Fxview or from about:addons

Expected result
Colorways closet should be correctly displayed.

Actual result
Colorways closet is displayed minimized with unnecessary scrolling bar.

Regression range
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1875b970dc64011b8a0b093ed432d0117d9758cb&tochange=dba4dc940ca9c180ac5ecc3011eb9761a3ca5026

Comment 1

[Dão Gottwald [:dao]]

What exactly does "minimized" mean in this context? Do you have a screenshot? Is this with the latest nightly, perhaps a regression from bug 1783011?

Comment 2

[Hani Yacoub, Desktop QA]

Attachment: Screenshot 2022-08-09 at 17.34.52.png

Comment 3

[Hani Yacoub, Desktop QA]

Sorry about that, I forgot to attach a screenshot.

Comment 4

[Dão Gottwald [:dao]]

I'm still confused about you saying this isn't a regression in comment 0. I would expect bug 1783011 to have made a difference here, for better or worse. Can you confirm that you're on the latest nightly (would you please copy and paste the source from about:buildconfig?), and that the behavior is the same as before when bug 1783011 wasn't fixed?

Comment 5

[Hani Yacoub, Desktop QA]

This issue appeared just after the latest Firefox Nightly update, regarding "Not a regression" I wanted to write that I will provide a regression range as soon as possible, my bad here.

Source:
Built from https://hg.mozilla.org/mozilla-central/rev/aeac2e82d88d2535598de558b8cc9069780f034d

I just did a regression range and here are the results: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1875b970dc64011b8a0b093ed432d0117d9758cb&tochange=dba4dc940ca9c180ac5ecc3011eb9761a3ca5026

Comment 6

[Dão Gottwald [:dao]]

Thanks!

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1783011

Comment 8

[Dão Gottwald [:dao]]

Attachment: Bug 1783887 - [Colorway Closet] Ensure we remove the document width only after SubDialog has done its work. r=gijs

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dd86d92d299
[Colorway Closet] Ensure we remove the document width only after SubDialog has done its work. r=Gijs

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8dd86d92d299

Comment 11

[Mehmet]

Attachment: Bildschirmfoto 2022-08-11 um 16.59.04.png

Hello Dão, I am still seeing this bug in todays Nightly build 105.0a1 (2022-08-11) (64-Bit). Please see the attached screenshot.

Is this still a known issue or a new one? Please let me know, if I should open a report for it.

Thanks.

Comment 12

[Hani Yacoub, Desktop QA]

Verified as fixed on macOS 11.6 on Firefox Nightly 105.0a1 (2022-08-16).